From 01af6ce11601a8b0a04dcd1085a9c1ca8b8d2897 Mon Sep 17 00:00:00 2001 From: wendrul Date: Mon, 18 Nov 2024 20:16:46 +0100 Subject: [PATCH] fix: playbook files permission mode incompatible with Windows --- backend/windmill-common/src/worker.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/backend/windmill-common/src/worker.rs b/backend/windmill-common/src/worker.rs index 2bd777623d..3630de0674 100644 --- a/backend/windmill-common/src/worker.rs +++ b/backend/windmill-common/src/worker.rs @@ -229,12 +229,18 @@ pub fn write_file_at_user_defined_location( let mut file = File::create(full_path)?; + #[cfg(unix)] if let Some(mode) = mode { let perm = std::os::unix::fs::PermissionsExt::from_mode(mode); file.set_permissions(perm) .map_err(|e| anyhow!("Failed to set permissions to {}: {e}", user_defined_path))?; } + #[cfg(windows)] + if mode.is_some() { + tracing::error!("Cannot use `mode` to set file permissions on windows workers"); + } + file.write_all(content.as_bytes())?; file.flush()?; Ok(normalized_full_path)