From 035c845d7fa208d8f6abd16b7047131095c67e1b Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Tue, 6 May 2025 19:09:01 +0200
Subject: [PATCH] improve handling of non parsable scripts on deploy

---
 backend/windmill-api/src/scripts.rs | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/backend/windmill-api/src/scripts.rs b/backend/windmill-api/src/scripts.rs
index ffdddc8e9d..080c07cc91 100644
--- a/backend/windmill-api/src/scripts.rs
+++ b/backend/windmill-api/src/scripts.rs
@@ -685,12 +685,32 @@ async fn create_script_internal<'c>(
 
     let (no_main_func, has_preprocessor) = match lang {
         ScriptLang::Bun | ScriptLang::Bunnative | ScriptLang::Deno | ScriptLang::Nativets => {
-            let args = windmill_parser_ts::parse_deno_signature(&ns.content, true, true, None)?;
-            (args.no_main_func, args.has_preprocessor)
+            let args = windmill_parser_ts::parse_deno_signature(&ns.content, true, true, None);
+            match args {
+                Ok(args) => (args.no_main_func, args.has_preprocessor),
+                Err(e) => {
+                    tracing::warn!(
+                        "Error parsing deno signature when deploying script {}: {:?}",
+                        ns.path,
+                        e
+                    );
+                    (None, None)
+                }
+            }
         }
         ScriptLang::Python3 => {
-            let args = windmill_parser_py::parse_python_signature(&ns.content, None, true)?;
-            (args.no_main_func, args.has_preprocessor)
+            let args = windmill_parser_py::parse_python_signature(&ns.content, None, true);
+            match args {
+                Ok(args) => (args.no_main_func, args.has_preprocessor),
+                Err(e) => {
+                    tracing::warn!(
+                        "Error parsing python signature when deploying script {}: {:?}",
+                        ns.path,
+                        e
+                    );
+                    (None, None)
+                }
+            }
         }
         _ => (ns.no_main_func, ns.has_preprocessor),
     };