From 03daa341eb91118c27e92b1b51731400a0dce30c Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Sat, 17 Jan 2026 21:04:18 +0000 Subject: [PATCH] fix: handle missing storage key in S3Object for write_s3_file Use .get("storage") instead of direct key access to prevent KeyError when s3object doesn't contain the optional storage field. Co-Authored-By: Claude Opus 4.5 --- python-client/wmill/wmill/client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python-client/wmill/wmill/client.py b/python-client/wmill/wmill/client.py index cb1b502223..19fee97a41 100644 --- a/python-client/wmill/wmill/client.py +++ b/python-client/wmill/wmill/client.py @@ -975,7 +975,7 @@ class Windmill: ).json() except Exception as e: raise Exception("Could not write file to S3") from e - return S3Object(s3=response["file_key"], storage=s3object["storage"]) + return S3Object(s3=response["file_key"], storage=s3object.get("storage") if s3object else None) def sign_s3_objects(self, s3_objects: list[S3Object | str]) -> list[S3Object]: """Sign S3 objects for use by anonymous users in public apps.