From 06f1f10b40a41f366e756bde18879d038e2e78b1 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Mon, 17 Feb 2025 11:49:06 +0100
Subject: [PATCH] improve version detection from source

---
 backend/windmill-common/src/utils.rs  | 7 +++++--
 backend/windmill-common/src/worker.rs | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/backend/windmill-common/src/utils.rs b/backend/windmill-common/src/utils.rs
index 735c3d4a27..0a6117999a 100644
--- a/backend/windmill-common/src/utils.rs
+++ b/backend/windmill-common/src/utils.rs
@@ -47,8 +47,11 @@ lazy_static::lazy_static! {
         .connect_timeout(std::time::Duration::from_secs(10))
         .build().unwrap();
     pub static ref GIT_SEM_VERSION: Version = Version::parse(
-        // skip first `v` character.
-        GIT_VERSION.split_at(1).1
+        if GIT_VERSION.starts_with('v') {
+            &GIT_VERSION[1..]
+        } else {
+            GIT_VERSION
+        }
     ).unwrap_or(Version::new(0, 1, 0));
 }
 
diff --git a/backend/windmill-common/src/worker.rs b/backend/windmill-common/src/worker.rs
index 487a217d7f..eb5bd1d6f1 100644
--- a/backend/windmill-common/src/worker.rs
+++ b/backend/windmill-common/src/worker.rs
@@ -657,7 +657,7 @@ pub async fn update_min_version<'c, E: sqlx::Executor<'c, Database = sqlx::Postg
     let min_version = pings
         .iter()
         .filter(|x| !x.is_empty())
-        .filter_map(|x| semver::Version::parse(x.split_at(1).1).ok())
+        .filter_map(|x| semver::Version::parse(if x.starts_with('v') { &x[1..] } else { x }).ok())
         .min()
         .unwrap_or_else(|| cur_version.clone());