diff --git a/frontend/src/lib/components/workspaceSettings/CreateWorkspace.svelte b/frontend/src/lib/components/workspaceSettings/CreateWorkspace.svelte index 03deff091e..13ce0662d1 100644 --- a/frontend/src/lib/components/workspaceSettings/CreateWorkspace.svelte +++ b/frontend/src/lib/components/workspaceSettings/CreateWorkspace.svelte @@ -16,7 +16,7 @@ {#if isFork} -
+
Forking diff --git a/frontend/src/lib/components/workspaceSettings/CreateWorkspaceInner.svelte b/frontend/src/lib/components/workspaceSettings/CreateWorkspaceInner.svelte index d6d7d336f4..b308206542 100644 --- a/frontend/src/lib/components/workspaceSettings/CreateWorkspaceInner.svelte +++ b/frontend/src/lib/components/workspaceSettings/CreateWorkspaceInner.svelte @@ -38,8 +38,10 @@ import { canUserBypassRuleKindInRulesets, fetchProtectionRulesForWorkspace, + getActiveRulesetsForKindInRulesets, isRuleActiveInRulesets, - isRuleUnconditionallyActiveInRulesets + isRuleUnconditionallyActiveInRulesets, + readProtectionRulesForWorkspace } from '$lib/workspaceProtectionRules.svelte' import { resource } from 'runed' import { getUserExt } from '$lib/user' @@ -292,24 +294,58 @@ // ParentWorkspaceProtectionAlert. const baseRuleContext = resource( () => (isFork ? baseWorkspaceId : undefined), - async (ws) => { + async (ws, _prev, { signal }) => { if (!ws) return undefined - const [rules, user] = await Promise.all([ - fetchProtectionRulesForWorkspace(ws), - getUserExt(ws) - ]) - return { rules, user } + const [rules, user] = await Promise.all([readProtectionRulesForWorkspace(ws), getUserExt(ws)]) + if (signal.aborted) throw new DOMException('superseded', 'AbortError') + return { ws, rules, user } } ) let requireIsolation = $derived.by(() => { const ctx = baseRuleContext.current + const rules = ctx?.rules ?? [] return ( !!ctx && - isRuleActiveInRulesets(ctx.rules, 'RequireIsolatedForks') && - !canUserBypassRuleKindInRulesets(ctx.rules, 'RequireIsolatedForks', ctx.user) + isRuleActiveInRulesets(rules, 'RequireIsolatedForks') && + !canUserBypassRuleKindInRulesets(rules, 'RequireIsolatedForks', ctx.user) ) }) + // The server lets admins and the rulesets' bypass list fork past `DisableWorkspaceForking` + // silently, so the form makes that an explicit choice, as direct deployment does. It fails + // closed: until the selected base's rules are read, nobody can tell whether a bypass applies. + let baseRulesForSelection = $derived.by(() => { + const ctx = baseRuleContext.current + return ctx && ctx.ws === baseWorkspaceId ? ctx : undefined + }) + let baseRulesUnreadable = $derived( + !!baseRulesForSelection && baseRulesForSelection.rules === undefined + ) + let forkingRulesets = $derived( + getActiveRulesetsForKindInRulesets( + baseRulesForSelection?.rules ?? [], + 'DisableWorkspaceForking' + ) + ) + let canBypassForkingRule = $derived( + canUserBypassRuleKindInRulesets( + forkingRulesets, + 'DisableWorkspaceForking', + baseRulesForSelection?.user + ) + ) + let forkingBypassConfirmed = $state(false) + $effect(() => { + baseWorkspaceId + forkingBypassConfirmed = false + }) + let forkingBlocked = $derived( + isFork && + !!baseWorkspaceId && + (baseRulesForSelection?.rules === undefined || + (forkingRulesets.length > 0 && !(canBypassForkingRule && forkingBypassConfirmed))) + ) + let workspaceColor: string | undefined = $state(undefined) let colorEnabled = $state(false) let errorHandlerFallbackToInstanceAlerts = $state(false) @@ -788,6 +824,40 @@ {/if} {/if} + {#if isFork && baseRulesUnreadable} + + Forking stays disabled until they can be checked. Reload the page to try again. + + {:else if isFork && forkingRulesets.length > 0} + +
+

+ The protection rule{forkingRulesets.length > 1 ? 's' : ''} + {forkingRulesets.map((r) => r.name).join(', ')} + disable{forkingRulesets.length > 1 ? '' : 's'} forking this workspace. + {#if canBypassForkingRule} + You can bypass {forkingRulesets.length > 1 ? 'them' : 'it'} as + {baseRulesForSelection?.user?.is_admin || + baseRulesForSelection?.user?.is_super_admin + ? 'an admin' + : 'one of its bypass users or groups'}. + {:else} + Only workspace admins and the rule's bypass users and groups can fork it. + {/if} +

+ {#if canBypassForkingRule} + + {/if} +
+
+ {/if} {#if !isFork}