From 0c8bc6077a539c7bd73eabbb1c180b409f179b63 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Mon, 14 Jul 2025 13:00:25 +0000
Subject: [PATCH] load secondary storages only on need

---
 frontend/src/lib/components/S3FilePicker.svelte | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/frontend/src/lib/components/S3FilePicker.svelte b/frontend/src/lib/components/S3FilePicker.svelte
index 59ddac2bef..5f0bfb89d6 100644
--- a/frontend/src/lib/components/S3FilePicker.svelte
+++ b/frontend/src/lib/components/S3FilePicker.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { run, createBubbler, stopPropagation } from 'svelte/legacy'
+	import { createBubbler, stopPropagation } from 'svelte/legacy'
 
 	const bubble = createBubbler()
 	import {
@@ -131,8 +131,11 @@
 		() => SettingService.getSecondaryStorageNames({ workspace: $workspaceStore! }),
 		{ loadInit: false }
 	)
+
+	let wasOpen = $state(false)
+
 	$effect(() => {
-		$workspaceStore && untrack(() => secondaryStorageNames.refresh())
+		wasOpen && $workspaceStore && untrack(() => secondaryStorageNames.refresh())
 	})
 
 	function onFilterChange() {
@@ -395,6 +398,7 @@
 
 	let storage: string | undefined = $state(undefined)
 	export async function open(_preSelectedFileKey: S3Object | undefined = undefined) {
+		wasOpen = true
 		const preSelectedFileKey = _preSelectedFileKey && parseS3Object(_preSelectedFileKey)
 		storage = preSelectedFileKey?.storage
 		if (preSelectedFileKey !== undefined) {
@@ -494,7 +498,7 @@
 			loadFileMetadataPlusPreviewAsync(selectedFileKey.s3)
 		}
 	}
-	run(() => {
+	$effect.pre(() => {
 		filter != undefined && untrack(() => onFilterChange())
 	})
 </script>