From 0e4653b0435f21a8ecae6b237afbc41bc5339309 Mon Sep 17 00:00:00 2001 From: hugocasa Date: Mon, 7 Sep 2026 19:49:00 +0200 Subject: [PATCH] docs: say what detaching the maintenance pass buys, and what it does not Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01C1xHmkxuxYb1GYvth1BS75 --- backend/src/monitor.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/backend/src/monitor.rs b/backend/src/monitor.rs index f788ec99a7..1fb6cf6b60 100644 --- a/backend/src/monitor.rs +++ b/backend/src/monitor.rs @@ -4318,9 +4318,11 @@ pub async fn monitor_db( // Re-check what each git-sync repository's own credential says about its expiry, // and rotate the ones close to it. Every ~40 min: the values move over days, and // `should_run` counts iterations in a u8. Spawned rather than joined: the join - // below is cancelled at its deadline, and a rotation cut off between GitLab - // issuing a token and Windmill storing it loses the token family. The pass's - // advisory lock keeps a slow one from overlapping the next. + // below is cancelled at its deadline, which a long sweep would reach, and a + // rotation cut off between GitLab issuing a token and Windmill storing it + // loses the token family. Detached, only process shutdown can cut it off, + // which a rotation almost never coincides with. The pass's advisory lock + // keeps a slow one from overlapping the next. let git_credential_maintenance_f = async { #[cfg(all(feature = "enterprise", feature = "private"))] if server_mode && iteration.is_some() && iteration.as_ref().unwrap().should_run(240) {