From 217bb2c9734a1fbd7a375c15d9a71a8d685fd77a Mon Sep 17 00:00:00 2001 From: Diego Imbert Date: Thu, 28 Aug 2025 15:49:23 +0200 Subject: [PATCH] implement todo --- backend/windmill-common/src/s3_helpers.rs | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/backend/windmill-common/src/s3_helpers.rs b/backend/windmill-common/src/s3_helpers.rs index 182fc1cf2f..89aa7caf3a 100644 --- a/backend/windmill-common/src/s3_helpers.rs +++ b/backend/windmill-common/src/s3_helpers.rs @@ -1119,8 +1119,19 @@ impl ObjectStoreResource { s3_resource.path_style, s3_resource.bucket.clone(), )), - _ => Err(error::Error::InternalErr( - "TODO only implemented for s3 for now".to_string(), + ObjectStoreResource::Gcs(gcs_resource) => Ok(format!( + "https://storage.googleapis.com/{}", + gcs_resource.bucket + )), + ObjectStoreResource::Azure(az_resource) => Ok(render_endpoint( + az_resource + .endpoint + .clone() + .unwrap_or_else(|| "".to_string()), + az_resource.use_ssl.unwrap_or(false), + None, + None, + "".to_string(), )), } }