From 279739ddd9e7abf232c3eab792dd656dfad506f8 Mon Sep 17 00:00:00 2001
From: HugoCasa <hugo@casademont.ch>
Date: Tue, 19 Nov 2024 19:58:55 +0100
Subject: [PATCH] app pdf nits (#4756)

---
 .../apps/components/display/AppPdf.svelte     | 30 ++-----------
 .../lib/components/display/PdfViewer.svelte   | 42 +++++++++----------
 2 files changed, 24 insertions(+), 48 deletions(-)

diff --git a/frontend/src/lib/components/apps/components/display/AppPdf.svelte b/frontend/src/lib/components/apps/components/display/AppPdf.svelte
index cdd6029418..1bdf303207 100644
--- a/frontend/src/lib/components/apps/components/display/AppPdf.svelte
+++ b/frontend/src/lib/components/apps/components/display/AppPdf.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { getContext } from 'svelte'
-	import { findGridItem, initOutput } from '../../editor/appUtils'
+	import { initOutput } from '../../editor/appUtils'
 	import type { AppViewerContext, ComponentCustomCSS, RichConfigurations } from '../../types'
 	import { initCss } from '../../utils'
 	import InputValue from '../helpers/InputValue.svelte'
@@ -13,8 +13,7 @@
 	export let customCss: ComponentCustomCSS<'pdfcomponent'> | undefined = undefined
 	export let render: boolean
 
-	const { app, mode, worldStore, selectedComponent } =
-		getContext<AppViewerContext>('AppViewerContext')
+	const { app, worldStore } = getContext<AppViewerContext>('AppViewerContext')
 
 	const outputs = initOutput($worldStore, id, {
 		loading: false
@@ -22,17 +21,6 @@
 
 	let source: string | ArrayBuffer | undefined = undefined
 	let zoom: number | undefined = undefined
-	function syncZoomValue() {
-		const gridItem = findGridItem($app, id)
-
-		//@ts-ignore
-		if (gridItem && gridItem.data.configuration.zoom.value !== zoom) {
-			//@ts-ignore
-			gridItem.data.configuration.zoom.value = zoom
-		}
-
-		$app = $app
-	}
 
 	let css = initCss($app.css?.pdfcomponent, customCss)
 </script>
@@ -65,18 +53,6 @@
 			on:loaded={() => {
 				outputs.loading.set(false)
 			}}
-		>
-			<svelte:fragment slot="extra-button">
-				{#if $mode !== 'preview' && $selectedComponent?.includes(id)}
-					<button
-						class="fixed z-10 bottom-0 left-0 px-2 py-0.5 bg-indigo-500/90
-			hover:bg-indigo-500 focus:bg-indigo-500 duration-200 text-white text-2xs"
-						on:click={() => syncZoomValue()}
-					>
-						Sync zoom value
-					</button>
-				{/if}
-			</svelte:fragment>
-		</PdfViewer>
+		/>
 	</div>
 {/if}
diff --git a/frontend/src/lib/components/display/PdfViewer.svelte b/frontend/src/lib/components/display/PdfViewer.svelte
index ac645209e3..ca9c071953 100644
--- a/frontend/src/lib/components/display/PdfViewer.svelte
+++ b/frontend/src/lib/components/display/PdfViewer.svelte
@@ -254,34 +254,34 @@
 					</span>
 				</div>
 				<div class="flex justify-end items-center px-2 text-secondary text-sm gap-1">
-					{#if allowFullscreen}
-						<Button
-							on:click={downloadPdf}
-							disabled={!doc}
-							size="xs"
-							color="light"
-							title="Download PDF"
-							aria-label="Download PDF"
-							btnClasses="!font-medium !px-2"
-						>
-							<Download size={14} />
-						</Button>
-					{/if}
 					<Button
-						on:click={() => (fullscreen = !fullscreen)}
+						on:click={downloadPdf}
 						disabled={!doc}
 						size="xs"
 						color="light"
-						title="Toggle fullscreen"
-						aria-label="Toggle fullscreen"
+						title="Download PDF"
+						aria-label="Download PDF"
 						btnClasses="!font-medium !px-2"
 					>
-						{#if fullscreen}
-							<Shrink size={14} />
-						{:else}
-							<Expand size={14} />
-						{/if}
+						<Download size={14} />
 					</Button>
+					{#if allowFullscreen}
+						<Button
+							on:click={() => (fullscreen = !fullscreen)}
+							disabled={!doc}
+							size="xs"
+							color="light"
+							title="Toggle fullscreen"
+							aria-label="Toggle fullscreen"
+							btnClasses="!font-medium !px-2"
+						>
+							{#if fullscreen}
+								<Shrink size={14} />
+							{:else}
+								<Expand size={14} />
+							{/if}
+						</Button>
+					{/if}
 				</div>
 			</div>
 		{:else}