From 2b875845543bbdf99a2db069f571ac90f2548df3 Mon Sep 17 00:00:00 2001 From: centdix <40307056+centdix@users.noreply.github.com> Date: Tue, 8 Jul 2025 12:53:26 +0200 Subject: [PATCH] internal: nits for claude demo (#6141) * nits for claude demo * better prompt --- .github/workflows/pr-ready-review.yml | 2 ++ frontend/src/lib/actions/triggerableByAI.svelte.ts | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-ready-review.yml b/.github/workflows/pr-ready-review.yml index 8140b8bb55..404f260ba1 100644 --- a/.github/workflows/pr-ready-review.yml +++ b/.github/workflows/pr-ready-review.yml @@ -38,4 +38,6 @@ jobs: Provide constructive feedback with specific suggestions for improvement. Use inline comments to highlight specific areas of concern. + + At the end of your review, add complete instructions to reproduce the added changes through the app interface. These instructions will be given to a tester so he can verify the changes. It should be a short descriptive text (not a step by step or a list) on how to navigate the app (what page, what action, what input, etc) to see the changes. allowed_tools: "mcp__github__create_pending_pull_request_review,mcp__github__add_pull_request_review_comment_to_pending_review,mcp__github__submit_pending_pull_request_review,mcp__github__get_pull_request_diff" diff --git a/frontend/src/lib/actions/triggerableByAI.svelte.ts b/frontend/src/lib/actions/triggerableByAI.svelte.ts index 5fd9950067..5f078b208b 100644 --- a/frontend/src/lib/actions/triggerableByAI.svelte.ts +++ b/frontend/src/lib/actions/triggerableByAI.svelte.ts @@ -61,11 +61,14 @@ export function triggerableByAI(element: HTMLElement, options: TriggerableByAIOp // register the triggerable const currentData = { description, onTrigger: handleTrigger } triggerablesByAi[id] = currentData + element.setAttribute('ai-description', description) } function unregister() { if (isDisabled || !id) return + element.removeAttribute('ai-description') + // unregister the triggerable if (triggerablesByAi[id]) { delete triggerablesByAi[id] @@ -77,7 +80,7 @@ export function triggerableByAI(element: HTMLElement, options: TriggerableByAIOp return { update(newOptions: TriggerableByAIOptions) { - ; ({ id, description, callback, showAnimation = true } = newOptions) + ;({ id, description, callback, showAnimation = true } = newOptions) register() }, destroy() {