From 2bed97bbcce8ff236f5b16c0a986104e35913492 Mon Sep 17 00:00:00 2001
From: dieriba <dieriba.pro@gmail.com>
Date: Sun, 26 Jan 2025 22:09:49 +0100
Subject: [PATCH] nits: show error and documentation link, add better name
 (#5141)

---
 .../windmill-api/src/postgres_triggers/trigger.rs    |  5 +++--
 .../postgres/PostgresTriggerEditorInner.svelte       | 12 ++++++++----
 .../triggers/postgres/RelationPicker.svelte          |  5 ++++-
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/backend/windmill-api/src/postgres_triggers/trigger.rs b/backend/windmill-api/src/postgres_triggers/trigger.rs
index 2e84c0c7ec..aba36d81c3 100644
--- a/backend/windmill-api/src/postgres_triggers/trigger.rs
+++ b/backend/windmill-api/src/postgres_triggers/trigger.rs
@@ -76,7 +76,7 @@ impl PostgresSimpleClient {
             .port(database.port)
             .user(&database.user)
             .replication_mode(rust_postgres::config::ReplicationMode::Logical);
-
+        
         if !database.password.is_empty() {
             config.password(&database.password);
         }
@@ -389,7 +389,8 @@ async fn listen_to_transactions(
                                 }
                             }
                             Err(err) => {
-                                tracing::error!("Postgres trigger error while trying to start_logical_replication_streaming: {}", err.to_string())
+                                tracing::error!("Postgres trigger error while trying to start logical replication streaming: {}", &err);
+                                disable_with_error(&postgres_trigger, &db, err.to_string()).await
                             }
                         }
                     }
diff --git a/frontend/src/lib/components/triggers/postgres/PostgresTriggerEditorInner.svelte b/frontend/src/lib/components/triggers/postgres/PostgresTriggerEditorInner.svelte
index 29bbbf0acd..6c0934817d 100644
--- a/frontend/src/lib/components/triggers/postgres/PostgresTriggerEditorInner.svelte
+++ b/frontend/src/lib/components/triggers/postgres/PostgresTriggerEditorInner.svelte
@@ -443,7 +443,7 @@
 									bind:selected={transaction_to_track}
 								/>
 							</Section>
-							<Section label="Publication">
+							<Section label="Table Tracking">
 								<p class="text-xs mb-3 text-tertiary">
 									Select the tables to track. You can choose to track
 									<strong>all tables in your database</strong>,
@@ -456,6 +456,7 @@
 									<Tab value="basic"
 										><div class="flex flex-row gap-1"
 											>Basic<Tooltip
+												documentationLink="https://www.windmill.dev/docs/core_concepts/postgres_triggers#define-what-to-track"
 												><p
 													>Choose the <strong>relations</strong> to track without worrying about the
 													underlying mechanics of creating a
@@ -469,6 +470,7 @@
 									<Tab value="advanced"
 										><div class="flex flex-row gap-1"
 											>Advanced<Tooltip
+												documentationLink="https://www.windmill.dev/docs/core_concepts/postgres_triggers#advanced"
 												><p
 													>Select a specific <strong>publication</strong> from your database to
 													track, and manage it by <strong>creating</strong>,
@@ -488,10 +490,11 @@
 												<RelationPicker bind:selectedTable bind:relations />
 											</TabContent>
 											<TabContent value="advanced">
-												<div class="flex flex-col gap-4"
+												<div class="flex flex-col gap-6"
 													><Section
-														label="Slot name"
+														label="Replication slot management"
 														tooltip="Choose and manage the slots for your trigger. You can create or delete slots. Both non-active slots and the currently used slot by the trigger (if any) will be retrieved from your database for management."
+														documentationLink="https://www.windmill.dev/docs/core_concepts/postgres_triggers#managing-postgres-replication-slots"
 													>
 														<div class="flex flex-col gap-3">
 															<ToggleButtonGroup
@@ -529,8 +532,9 @@
 													</Section>
 
 													<Section
-														label="Publication"
+														label="Publication management"
 														tooltip="Select and manage the publications for tracking data. You can create, update, or delete publications. Only existing publications in your database will be available for selection, giving you full control over what data is tracked."
+														documentationLink="https://www.windmill.dev/docs/core_concepts/postgres_triggers#managing-postgres-publications"
 													>
 														<div class="flex flex-col gap-3">
 															<ToggleButtonGroup
diff --git a/frontend/src/lib/components/triggers/postgres/RelationPicker.svelte b/frontend/src/lib/components/triggers/postgres/RelationPicker.svelte
index 56ecdf7e27..5a4005919f 100644
--- a/frontend/src/lib/components/triggers/postgres/RelationPicker.svelte
+++ b/frontend/src/lib/components/triggers/postgres/RelationPicker.svelte
@@ -49,6 +49,7 @@
 									<label class="flex flex-col w-full">
 										<div class="text-secondary text-sm mb-2 flex flex-row gap-1"
 											><p>Columns</p><Tooltip
+												documentationLink="https://www.windmill.dev/docs/core_concepts/postgres_triggers#selecting-specific-columns"
 												><p>
 													Enter the names of the <strong>columns</strong> you want to track.
 													<br />If no columns are specified, all columns in the table will be
@@ -81,7 +82,9 @@
 									</label>
 									<label class="flex flex-col w-full">
 										<div class="text-secondary text-sm mb-2 flex flex-row gap-1"
-											><p>Where Clause</p><Tooltip>
+											><p>Where Clause</p><Tooltip
+												documentationLink="https://www.windmill.dev/docs/core_concepts/postgres_triggers#filtering-rows-with-where-condition"
+											>
 												<p class="text-sm">
 													Use this field to define a row filter for the selected table. The <strong
 														>WHERE</strong