From 32fed9b86205d4e657b56302aae1655972841190 Mon Sep 17 00:00:00 2001
From: Alexander Petric <alpetric@users.noreply.github.com>
Date: Thu, 27 Mar 2025 12:17:57 -0400
Subject: [PATCH] adding doc link to the gh app ui + updating descripton
 (#5521)

* adding doc link to the gh app ui + updating descripton

* Update frontend/src/lib/components/meltComponents/Popover.svelte

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* Update frontend/src/lib/components/ApiConnectForm.svelte

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
---
 frontend/src/lib/components/ApiConnectForm.svelte        | 6 +++---
 frontend/src/lib/components/AppConnectInner.svelte       | 1 +
 .../src/lib/components/meltComponents/Popover.svelte     | 9 ++++++++-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/frontend/src/lib/components/ApiConnectForm.svelte b/frontend/src/lib/components/ApiConnectForm.svelte
index 32ee3e3cba..50b7a15917 100644
--- a/frontend/src/lib/components/ApiConnectForm.svelte
+++ b/frontend/src/lib/components/ApiConnectForm.svelte
@@ -25,6 +25,7 @@
 	export let linkedSecret: string | undefined = undefined
 	export let isValid = true
 	export let linkedSecretCandidates: string[] | undefined = undefined
+	export let description: string | undefined = undefined
 
 	let schema = emptySchema()
 	let notFound = false
@@ -226,14 +227,12 @@
 			{
 				...args,
 				url: selectedGHAppRepository,
-				github_app_installation_id: githubInstallations.find(
-					(_) => _.account_id === selectedGHAppAccountId
-				)?.installation_id,
 				is_github_app: true
 			},
 			null,
 			2
 		)
+		description = `Repository ${selectedGHAppRepository} with permissions fetched using Windmill Github App. ${description ?? ''}`
 		rawCodeEditor?.setCode(rawCode)
 		close(null)
 	}
@@ -409,6 +408,7 @@
 			{/if}
 			{#if githubInstallations.length > 0}
 				<Popover
+					documentationLink="https://www.windmill.dev/docs/integrations/git_repository#github-app"
 					bind:this={githubAppPopover}
 					floatingConfig={{
 						placement: 'bottom'
diff --git a/frontend/src/lib/components/AppConnectInner.svelte b/frontend/src/lib/components/AppConnectInner.svelte
index 02136a91dc..8877e8f548 100644
--- a/frontend/src/lib/components/AppConnectInner.svelte
+++ b/frontend/src/lib/components/AppConnectInner.svelte
@@ -564,6 +564,7 @@
 			{#key resourceTypeInfo}
 				<ApiConnectForm
 					bind:linkedSecret
+					bind:description
 					{linkedSecretCandidates}
 					{resourceType}
 					{resourceTypeInfo}
diff --git a/frontend/src/lib/components/meltComponents/Popover.svelte b/frontend/src/lib/components/meltComponents/Popover.svelte
index cd3d89fc28..c1c14314d0 100644
--- a/frontend/src/lib/components/meltComponents/Popover.svelte
+++ b/frontend/src/lib/components/meltComponents/Popover.svelte
@@ -14,6 +14,7 @@
 	import { pointerDownOutside } from '$lib/utils'
 	import { twMerge } from 'tailwind-merge'
 	import { createEventDispatcher } from 'svelte'
+	import DocLink from '$lib/components/apps/editor/settingsPanel/DocLink.svelte'
 
 	export let closeButton: boolean = false
 	export let displayArrow: boolean = false
@@ -27,6 +28,7 @@
 	export let portal: string | HTMLElement | null = 'body'
 	export let closeOnOtherPopoverOpen: boolean = false
 	export let disabled: boolean = false
+	export let documentationLink: string | undefined = undefined
 
 	const dispatch = createEventDispatcher()
 
@@ -85,7 +87,7 @@
 	class={$$props.class}
 	use:melt={$trigger}
 	aria-label="Popup button"
-	disabled={disabled}
+	{disabled}
 	on:mouseenter={() => (openOnHover ? open() : null)}
 	on:mouseleave={() => (openOnHover ? close() : null)}
 	use:pointerDownOutside={{
@@ -114,6 +116,11 @@
 		{#if displayArrow}
 			<div use:melt={$arrow} />
 		{/if}
+		{#if documentationLink}
+			<div class="absolute right-1.5 top-1.5">
+				<DocLink docLink={documentationLink} size="sm" />
+			</div>
+		{/if}
 		<slot name="content" {open} {close} />
 		{#if closeButton}
 			<button class="close" use:melt={$closeElement}>