From 39dc6857eb5c19f5a69c2a8e259b922e2ad2290d Mon Sep 17 00:00:00 2001 From: wendrul <53628737+wendrul@users.noreply.github.com> Date: Tue, 6 Aug 2024 10:48:53 +0200 Subject: [PATCH] Remove admin requirement to cancel job selection (#4188) --- backend/windmill-api/src/jobs.rs | 1 - frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/windmill-api/src/jobs.rs b/backend/windmill-api/src/jobs.rs index f5ece1b195..706f588c9c 100644 --- a/backend/windmill-api/src/jobs.rs +++ b/backend/windmill-api/src/jobs.rs @@ -1462,7 +1462,6 @@ async fn cancel_selection( Path(w_id): Path, Json(jobs): Json>, ) -> error::JsonResult> { - require_admin(authed.is_admin, &authed.username)?; let mut tx = user_db.begin(&authed).await?; let jobs_to_cancel = sqlx::query_scalar!( diff --git a/frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte index 864ecd8fe9..fc6326f0ec 100644 --- a/frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte +++ b/frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte @@ -473,6 +473,7 @@ selectedIds = [] jobLoader?.loadJobs(minTs, maxTs, true, true) sendUserToast(`Canceled ${uuids.length} jobs`) + isSelectingJobsToCancel = false }} loading={fetchingFilteredJobs} on:canceled={() => { @@ -496,6 +497,7 @@ selectedIds = [] jobLoader?.loadJobs(minTs, maxTs, true, true) sendUserToast(`Canceled ${uuids.length} jobs`) + isSelectingJobsToCancel = false }} on:canceled={() => { isCancelingVisibleJobs = false