From 3aed54cb15c1fc8f625d26a7208853035533bfd4 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Mon, 4 May 2026 21:43:13 +0000 Subject: [PATCH] nit chore review --- .github/review-prompt-shared.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/review-prompt-shared.md b/.github/review-prompt-shared.md index 2070247fd0..0b8d8df253 100644 --- a/.github/review-prompt-shared.md +++ b/.github/review-prompt-shared.md @@ -8,6 +8,16 @@ You are reviewing a GitHub pull request for this repository. Apply this policy a - `CLAUDE.md` in this repo is a wrapper around `AGENTS.md` (`@AGENTS.md`) — the same content. - Quote the exact rule from `AGENTS.md` when flagging a violation. +## Verdict (first line of the review) + +Start every review with a single verdict line, before any other section. Pick exactly one: + +- **Good to merge** — no blocking issues and no nits worth surfacing. +- **Mergeable, but should ideally address nits: ** — no blockers, but P2 findings that are worth a look. The list must name each nit briefly (e.g. "doc/code mismatch in `foo.rs`, half-finished `pub fn bar`"). +- **Should address issues before merging: ** — at least one P0 or P1 finding. The list must name each blocking issue briefly (e.g. "missing auth check on new `/api/x` handler, SQL injection in `build_query`"). + +The names in the list must match findings detailed later in the review. If you list a nit or issue here, it must appear with full context in the body. Do not invent items that aren't in the body, and do not bury blockers in the body without surfacing them in the verdict. + ## Review policy - Only report issues you are confident are real and introduced by this pull request.