starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-06 08:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: python results with a KeyError-raising __getattr__ fail the job (#11517)

Browse Source 
* fix: python results with a KeyError-raising __getattr__ no longer fail

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix: keep the stream probe on the instance so enum results still serialize

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix: probe python results through class dicts, never their __getattr__

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-10-05 08:20:52 +02:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 289d3c3941
commit 3fff1bd3dc
3 changed files with 47 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python-client/wmill/wmill/s3_types.py
+16 -7
View File
@@ -1,6 +1,15 @@
from typing import Optional
def _item_as_attr(d: dict, attr: str):
# AttributeError, not KeyError: hasattr, copy and pickle probe optional
# attributes and only treat AttributeError as "absent".
try:
return d[attr]
except KeyError:
raise AttributeError(attr) from None
class S3Object(dict):
"""S3 file reference with file key, optional storage identifier, and presigned token."""
s3: str
@@ -8,7 +17,7 @@ class S3Object(dict):
presigned: Optional[str]
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)
class S3FsClientKwargs(dict):
@@ -16,7 +25,7 @@ class S3FsClientKwargs(dict):
region_name: str
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)
class S3FsArgs(dict):
@@ -29,7 +38,7 @@ class S3FsArgs(dict):
client_kwargs: S3FsClientKwargs
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)
class StorageOptions(dict):
@@ -41,7 +50,7 @@ class StorageOptions(dict):
aws_allow_http: str
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)
class PolarsConnectionSettings(dict):
@@ -50,7 +59,7 @@ class PolarsConnectionSettings(dict):
storage_options: StorageOptions
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)
class Boto3ConnectionSettings(dict):
@@ -63,7 +72,7 @@ class Boto3ConnectionSettings(dict):
aws_session_token: Optional[str]
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)
class DuckDbConnectionSettings(dict):
@@ -71,4 +80,4 @@ class DuckDbConnectionSettings(dict):
connection_settings_str: str
def __getattr__(self, attr):
return self[attr]
return _item_as_attr(self, attr)