From 4788c393e910534ffd46ef48e44fcf35d510c227 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Sun, 17 Mar 2024 19:13:51 +0100 Subject: [PATCH] avoid caching binary on cloud --- backend/windmill-worker/src/go_executor.rs | 25 ++++++++++++---------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/backend/windmill-worker/src/go_executor.rs b/backend/windmill-worker/src/go_executor.rs index d7e1ac6cd3..6ab612d495 100644 --- a/backend/windmill-worker/src/go_executor.rs +++ b/backend/windmill-worker/src/go_executor.rs @@ -12,6 +12,7 @@ use windmill_common::{ error::{self, Error}, jobs::QueuedJob, utils::calculate_hash, + worker::CLOUD_HOSTED, }; use windmill_parser_go::{parse_go_imports, REQUIRE_PARSE}; use windmill_queue::{append_logs, CanceledBy}; @@ -61,7 +62,7 @@ pub async fn handle_go_job( .unwrap_or_default() )) ); - let bin_exists = tokio::fs::metadata(&bin_path).await.is_ok(); + let bin_exists = !*CLOUD_HOSTED && tokio::fs::metadata(&bin_path).await.is_ok(); let (skip_go_mod, skip_tidy) = if bin_exists { create_dir(job_dir).await?; @@ -208,16 +209,18 @@ func Run(req Req) (interface{{}}, error){{ ) .await?; - create_dir(&bin_path).await?; - let target = format!("{bin_path}/main"); - tokio::fs::copy(format!("{job_dir}/main"), &target).await?; - append_logs( - job.id.clone(), - job.workspace_id.to_string(), - format!("write cached binary: {}\n", bin_path), - db, - ) - .await; + if !*CLOUD_HOSTED { + create_dir(&bin_path).await?; + let target = format!("{bin_path}/main"); + tokio::fs::copy(format!("{job_dir}/main"), &target).await?; + append_logs( + job.id.clone(), + job.workspace_id.to_string(), + format!("write cached binary: {}\n", bin_path), + db, + ) + .await; + } } else { let path = format!("{bin_path}/main"); let mut logs2 = "".to_string();