From 50dc4766520c3fcffe26d398ed1e4ff5d7464e1f Mon Sep 17 00:00:00 2001 From: AlexRV12 <71396855+AlexRV12@users.noreply.github.com> Date: Thu, 27 Aug 2026 11:13:20 +0200 Subject: [PATCH] refactor: share the disabled-field reset toast between the two run forms --- frontend/src/lib/components/RunForm.svelte | 6 ++---- .../lib/components/copilot/chat/RunArgsFormDisplay.svelte | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/frontend/src/lib/components/RunForm.svelte b/frontend/src/lib/components/RunForm.svelte index 99ba0f45c7..510f774587 100644 --- a/frontend/src/lib/components/RunForm.svelte +++ b/frontend/src/lib/components/RunForm.svelte @@ -24,7 +24,7 @@ import InputSelectedBadge from './schema/InputSelectedBadge.svelte' import { untrack } from 'svelte' import { processSecretArgs } from './secretArgUtils' - import { enforceDisabledDefaults } from './job_args' + import { enforceDisabledDefaults, resetKeysToast } from './job_args' import PowerShellCommonParams from './PowerShellCommonParams.svelte' let reloadArgs = $state(0) @@ -63,9 +63,7 @@ let processedArgs: Record const { args: withDefaults, resetKeys } = enforceDisabledDefaults(args ?? {}, runnable?.schema) if (resetKeys.length > 0) { - sendUserToast( - `Disabled field${resetKeys.length > 1 ? 's' : ''} ${resetKeys.map((k) => `'${k}'`).join(', ')} reset to default value${resetKeys.length > 1 ? 's' : ''}` - ) + sendUserToast(resetKeysToast(resetKeys)) } try { processedArgs = await processSecretArgs(withDefaults, runnable?.schema) diff --git a/frontend/src/lib/components/copilot/chat/RunArgsFormDisplay.svelte b/frontend/src/lib/components/copilot/chat/RunArgsFormDisplay.svelte index 9aa87cd402..f3ccd96d84 100644 --- a/frontend/src/lib/components/copilot/chat/RunArgsFormDisplay.svelte +++ b/frontend/src/lib/components/copilot/chat/RunArgsFormDisplay.svelte @@ -4,7 +4,7 @@ import Button from '$lib/components/common/button/Button.svelte' import SchemaForm from '$lib/components/SchemaForm.svelte' import { processSecretArgs } from '$lib/components/secretArgUtils' - import { enforceDisabledDefaults } from '$lib/components/job_args' + import { enforceDisabledDefaults, resetKeysToast } from '$lib/components/job_args' import { sendUserToast } from '$lib/utils' import { getAiChatManager } from './aiChatManagerContext' import { PLAN_MODE_MESSAGES } from './planModeMessages' @@ -74,9 +74,7 @@ // JSON editor to holds keys no schema names, and they are still theirs. const { args: enforced, resetKeys } = enforceDisabledDefaults(args ?? {}, schema) if (resetKeys.length > 0) { - sendUserToast( - `Disabled field${resetKeys.length > 1 ? 's' : ''} ${resetKeys.map((k) => `'${k}'`).join(', ')} reset to default value${resetKeys.length > 1 ? 's' : ''}` - ) + sendUserToast(resetKeysToast(resetKeys)) } let processed: Record try {