starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-27 08:02:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review findings on decision output

Browse Source 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-09-21 17:55:12 +02:00
co-authored by Claude Opus 5
parent 007197fbd6
commit 50ef72d7c8
16 changed files with 131 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-api/src/ai_evals/run.rs
+13 -5
View File
@@ -246,6 +246,14 @@ fn build_run_flow(
}))?)
}
/// Each agent input a case supplies, with the case input it is read from. A case carries a message,
/// which a decision agent is asked its questions about: `state` is read by no other output type.
const CASE_INPUTS: [(&str, &str); 3] = [
("user_message", "user_message"),
("user_attachments", "user_attachments"),
("state", "user_message"),
];
/// The agent step, reading its case from the iteration rather than from the flow's arguments.
fn agent_module(config: &AgentDraft) -> Result<serde_json::Value> {
let flow = build_case_flow(config)?;
@@ -255,12 +263,12 @@ fn agent_module(config: &AgentDraft) -> Result<serde_json::Value> {
.entry("input_transforms")
.or_insert_with(|| serde_json::json!({}));
if let Some(transforms) = transforms.as_object_mut() {
for key in ["user_message", "user_attachments"] {
for (key, input) in CASE_INPUTS {
transforms.insert(
key.to_string(),
serde_json::json!({
"type": "javascript",
"expr": format!("flow_input.iter.value.input.{}", key),
"expr": format!("flow_input.iter.value.input.{}", input),
}),
);
}
@@ -273,15 +281,15 @@ fn agent_module(config: &AgentDraft) -> Result<serde_json::Value> {
/// through `FlowValue` rather than trusted as raw JSON.
fn build_case_flow(config: &AgentDraft) -> Result<windmill_common::flows::FlowValue> {
// The configuration runs exactly as authored: its own brain transforms are the module's, and
// the case supplies the message and the attachments over the top.
// the case supplies its inputs (`CASE_INPUTS`) over the top.
let mut input_transforms = match &config.input_transforms {
serde_json::Value::Object(map) => map.clone(),
_ => serde_json::Map::new(),
};
for key in ["user_message", "user_attachments"] {
for (key, input) in CASE_INPUTS {
input_transforms.insert(
key.to_string(),
serde_json::json!({ "type": "javascript", "expr": format!("flow_input.{}", key) }),
serde_json::json!({ "type": "javascript", "expr": format!("flow_input.{}", input) }),
);
}