From 53feb9239e9536c2bf2f423197e5d67867d5e747 Mon Sep 17 00:00:00 2001 From: Diego Imbert Date: Tue, 2 Dec 2025 12:28:09 +0100 Subject: [PATCH] remove ducklake/datatable and default --- .../windmill-parser-py/src/asset_parser.rs | 31 +++++++------------ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/backend/parsers/windmill-parser-py/src/asset_parser.rs b/backend/parsers/windmill-parser-py/src/asset_parser.rs index 730ed323d9..8665fb4911 100644 --- a/backend/parsers/windmill-parser-py/src/asset_parser.rs +++ b/backend/parsers/windmill-parser-py/src/asset_parser.rs @@ -74,17 +74,15 @@ impl AssetsFinder { .ok_or(())?; use AssetKind::*; - let (kind, access_type, arg, default) = match ident.as_str() { - "load_s3_file" => (S3Object, Some(R), Arg(0, "s3object"), None), - "load_s3_file_reader" => (S3Object, Some(R), Arg(0, "s3object"), None), - "write_s3_file" => (S3Object, Some(W), Arg(0, "s3object"), None), - "get_resource" => (Resource, None, Arg(0, "path"), None), - "set_resource" => (Resource, Some(W), Arg(0, "path"), None), - "get_boto3_connection_settings" => (Resource, None, Arg(0, "s3_resource_path"), None), - "get_polars_connection_settings" => (Resource, None, Arg(0, "s3_resource_path"), None), - "get_duckdb_connection_settings" => (Resource, None, Arg(0, "s3_resource_path"), None), - "datatable" => (DataTable, None, Arg(0, "name"), Some("main")), - "ducklake" => (Ducklake, None, Arg(0, "name"), Some("main")), + let (kind, access_type, arg) = match ident.as_str() { + "load_s3_file" => (S3Object, Some(R), Arg(0, "s3object")), + "load_s3_file_reader" => (S3Object, Some(R), Arg(0, "s3object")), + "write_s3_file" => (S3Object, Some(W), Arg(0, "s3object")), + "get_resource" => (Resource, None, Arg(0, "path")), + "set_resource" => (Resource, Some(W), Arg(0, "path")), + "get_boto3_connection_settings" => (Resource, None, Arg(0, "s3_resource_path")), + "get_polars_connection_settings" => (Resource, None, Arg(0, "s3_resource_path")), + "get_duckdb_connection_settings" => (Resource, None, Arg(0, "s3_resource_path")), _ => return Err(()), }; @@ -98,19 +96,12 @@ impl AssetsFinder { }), }; - match (arg_val, default) { - (Some(Expr::Constant(ExprConstant { value: Constant::Str(value), .. })), _) => { + match arg_val { + Some(Expr::Constant(ExprConstant { value: Constant::Str(value), .. })) => { let path = parse_asset_syntax(&value).map(|(_, p)| p).unwrap_or(&value); self.assets .push(ParseAssetsResult { kind, path: path.to_string(), access_type }); } - (None, Some(default)) => { - self.assets.push(ParseAssetsResult { - kind, - path: default.to_string(), - access_type, - }); - } _ => return Err(()), }; Ok(())