From 5bf5ff28bc4f9d47c4473cd5e71e0ee274dece31 Mon Sep 17 00:00:00 2001 From: Guilhem Date: Thu, 19 Nov 2026 14:21:51 +0100 Subject: [PATCH] fix: stop hidden session preview tabs from acting on keys (#12531) * fix: stop hidden session preview tabs from acting on keys Co-Authored-By: Claude Opus 5.5 * fix: type HostWindow key handlers as window keyboard handlers Co-Authored-By: Claude Opus 5.5 --------- Co-authored-by: Claude Opus 5.5 --- .../lib/components/AssignableTagsInner.svelte | 3 ++- .../lib/components/DBManagerContent.svelte | 3 ++- frontend/src/lib/components/DBTable.svelte | 3 +++ .../lib/components/DdlMigrationGuard.svelte | 3 ++- frontend/src/lib/components/Editor.svelte | 3 ++- .../src/lib/components/FirstStepInputs.svelte | 3 ++- .../src/lib/components/FlowBuilder.svelte | 10 +++++--- .../FlowLoopIterationPreview.svelte | 3 ++- .../lib/components/FlowPreviewContent.svelte | 3 ++- .../src/lib/components/HistoricInputs.svelte | 3 ++- frontend/src/lib/components/JsonInputs.svelte | 3 ++- .../lib/components/SavedInputsPicker.svelte | 3 ++- .../src/lib/components/ScriptBuilder.svelte | 10 +++++--- .../src/lib/components/ScriptEditor.svelte | 3 ++- .../display/InsertRowDrawerButton.svelte | 3 ++- .../assets/AssetGraph/AssetGraphCanvas.svelte | 3 +++ .../lib/components/common/HostWindow.svelte | 19 +++++++++++++++ .../chat/AppAvailableContextList.svelte | 3 +++ .../copilot/chat/ChatCommandPicker.svelte | 4 +++- .../copilot/chat/ChatContextPicker.svelte | 4 +++- .../src/lib/components/dbt/DbtEditor.svelte | 3 ++- .../flows/content/AgentEditorModal.svelte | 10 +++++--- .../components/flows/content/FlowInput.svelte | 3 ++- .../flows/content/FlowInputsQuick.svelte | 3 ++- .../flows/content/FlowModuleComponent.svelte | 3 ++- .../flows/content/GenAiQuick.svelte | 3 ++- .../flows/map/FlowModuleSchemaMap.svelte | 4 +++- .../flows/map/InsertModuleInner.svelte | 3 ++- .../pickers/FlowScriptPickerQuick.svelte | 3 ++- .../flows/pickers/FlowToplevelNode.svelte | 3 ++- .../flows/pickers/PickHubScriptQuick.svelte | 3 ++- .../pickers/WorkspaceScriptPickerQuick.svelte | 3 ++- .../lib/components/graph/FlowGraphV2.svelte | 3 +++ .../src/lib/components/jobs/JobPreview.svelte | 7 +++--- .../components/raw_apps/RawAppEditor.svelte | 12 +++++++--- .../src/lib/components/runs/RunsTable.svelte | 4 +++- .../components/sessions/PreviewTabHost.svelte | 23 +++++++++++-------- .../components/triggers/CaptureTable.svelte | 3 ++- 38 files changed, 136 insertions(+), 52 deletions(-) create mode 100644 frontend/src/lib/components/common/HostWindow.svelte diff --git a/frontend/src/lib/components/AssignableTagsInner.svelte b/frontend/src/lib/components/AssignableTagsInner.svelte index fd5859b784..3da1163158 100644 --- a/frontend/src/lib/components/AssignableTagsInner.svelte +++ b/frontend/src/lib/components/AssignableTagsInner.svelte @@ -1,4 +1,5 @@ - + {#snippet reachesAnyTagWarning(scoped: boolean)} Nothing fixed at its start or its end, so it allows anyone{scoped ? ' in its workspaces' : ''} to reach diff --git a/frontend/src/lib/components/DBManagerContent.svelte b/frontend/src/lib/components/DBManagerContent.svelte index 8894043688..9543f7a9e3 100644 --- a/frontend/src/lib/components/DBManagerContent.svelte +++ b/frontend/src/lib/components/DBManagerContent.svelte @@ -1,4 +1,5 @@ - { if (e.key === 'Escape') { if (replResultData) { diff --git a/frontend/src/lib/components/DBTable.svelte b/frontend/src/lib/components/DBTable.svelte index 03f26ced21..0ea2ec0fc5 100644 --- a/frontend/src/lib/components/DBTable.svelte +++ b/frontend/src/lib/components/DBTable.svelte @@ -33,6 +33,7 @@ - + 1 ? 'Schema changes detected' : 'Schema change detected'} diff --git a/frontend/src/lib/components/Editor.svelte b/frontend/src/lib/components/Editor.svelte index 65a09be8a9..da930c03f4 100644 --- a/frontend/src/lib/components/Editor.svelte +++ b/frontend/src/lib/components/Editor.svelte @@ -5,6 +5,7 @@ - + {#if datatableForMigrations && $operatingWorkspace} + import HostWindow from '$lib/components/common/HostWindow.svelte' import { createEventDispatcher, onDestroy, getContext, untrack } from 'svelte' import { getFirstStepSchema } from '$lib/components/flows/flowStore.svelte' import type { FlowEditorContext } from '$lib/components/flows/types' @@ -71,7 +72,7 @@ } - +
{#if schema && mod} diff --git a/frontend/src/lib/components/FlowBuilder.svelte b/frontend/src/lib/components/FlowBuilder.svelte index e9a65d243c..6a545423f8 100644 --- a/frontend/src/lib/components/FlowBuilder.svelte +++ b/frontend/src/lib/components/FlowBuilder.svelte @@ -1,4 +1,6 @@ - + {@render children?.()} diff --git a/frontend/src/lib/components/FlowLoopIterationPreview.svelte b/frontend/src/lib/components/FlowLoopIterationPreview.svelte index 8da0ee390e..0e05223456 100644 --- a/frontend/src/lib/components/FlowLoopIterationPreview.svelte +++ b/frontend/src/lib/components/FlowLoopIterationPreview.svelte @@ -1,4 +1,5 @@ - +
diff --git a/frontend/src/lib/components/FlowPreviewContent.svelte b/frontend/src/lib/components/FlowPreviewContent.svelte index 23e9622b7e..5880a4ceeb 100644 --- a/frontend/src/lib/components/FlowPreviewContent.svelte +++ b/frontend/src/lib/components/FlowPreviewContent.svelte @@ -1,4 +1,5 @@ - +
{#if render} diff --git a/frontend/src/lib/components/HistoricInputs.svelte b/frontend/src/lib/components/HistoricInputs.svelte index 48d1290356..348a810aaf 100644 --- a/frontend/src/lib/components/HistoricInputs.svelte +++ b/frontend/src/lib/components/HistoricInputs.svelte @@ -1,4 +1,5 @@ - +
diff --git a/frontend/src/lib/components/JsonInputs.svelte b/frontend/src/lib/components/JsonInputs.svelte index 546ab36069..2f86fc4850 100644 --- a/frontend/src/lib/components/JsonInputs.svelte +++ b/frontend/src/lib/components/JsonInputs.svelte @@ -1,4 +1,5 @@ - + diff --git a/frontend/src/lib/components/SavedInputsPicker.svelte b/frontend/src/lib/components/SavedInputsPicker.svelte index 38b9df414f..dcc23950f5 100644 --- a/frontend/src/lib/components/SavedInputsPicker.svelte +++ b/frontend/src/lib/components/SavedInputsPicker.svelte @@ -1,4 +1,5 @@ - +
{#if !noButton} diff --git a/frontend/src/lib/components/ScriptBuilder.svelte b/frontend/src/lib/components/ScriptBuilder.svelte index cdd356e023..29c5b79797 100644 --- a/frontend/src/lib/components/ScriptBuilder.svelte +++ b/frontend/src/lib/components/ScriptBuilder.svelte @@ -1,4 +1,6 @@ - + {@render children?.()} + import HostWindow from '$lib/components/common/HostWindow.svelte' import { MultiplayerConnection } from '$lib/multiplayerConnection' import { paneMinPercent } from '$lib/utils/splitpaneSizing' import { processSecretArgs } from './secretArgUtils' @@ -1870,7 +1871,7 @@ bind:job={testJob} /> - +
+ import HostWindow from '$lib/components/common/HostWindow.svelte' import { Alert, Drawer, DrawerContent, Button, ButtonType } from '$lib/components/common' import { CornerDownLeft, Plus } from 'lucide-svelte' import InsertRow from './dbtable/InsertRow.svelte' @@ -49,7 +50,7 @@ } - { if (drawerOpen && (e.ctrlKey || e.metaKey) && e.key === 'Enter') { onConfirm() diff --git a/frontend/src/lib/components/assets/AssetGraph/AssetGraphCanvas.svelte b/frontend/src/lib/components/assets/AssetGraph/AssetGraphCanvas.svelte index e46d761671..f4d339f7ae 100644 --- a/frontend/src/lib/components/assets/AssetGraph/AssetGraphCanvas.svelte +++ b/frontend/src/lib/components/assets/AssetGraph/AssetGraphCanvas.svelte @@ -1,4 +1,5 @@ + + hostActive() && onkeydown?.(e)} + onkeydowncapture={(e) => hostActive() && onkeydowncapture?.(e)} +/> diff --git a/frontend/src/lib/components/copilot/chat/AppAvailableContextList.svelte b/frontend/src/lib/components/copilot/chat/AppAvailableContextList.svelte index f120c89221..39fcbc47f8 100644 --- a/frontend/src/lib/components/copilot/chat/AppAvailableContextList.svelte +++ b/frontend/src/lib/components/copilot/chat/AppAvailableContextList.svelte @@ -1,4 +1,6 @@ - + diff --git a/frontend/src/lib/components/flows/content/FlowInputsQuick.svelte b/frontend/src/lib/components/flows/content/FlowInputsQuick.svelte index c0420b8da4..96092e0811 100644 --- a/frontend/src/lib/components/flows/content/FlowInputsQuick.svelte +++ b/frontend/src/lib/components/flows/content/FlowInputsQuick.svelte @@ -4,6 +4,7 @@ - +
{#if selectedKind != 'preprocessor'}
diff --git a/frontend/src/lib/components/flows/content/FlowModuleComponent.svelte b/frontend/src/lib/components/flows/content/FlowModuleComponent.svelte index 81863d21e6..7959e9fd3c 100644 --- a/frontend/src/lib/components/flows/content/FlowModuleComponent.svelte +++ b/frontend/src/lib/components/flows/content/FlowModuleComponent.svelte @@ -1,4 +1,5 @@ - + {#if flowModule.value}
diff --git a/frontend/src/lib/components/flows/content/GenAiQuick.svelte b/frontend/src/lib/components/flows/content/GenAiQuick.svelte index 5d3814fb63..14d3bebf52 100644 --- a/frontend/src/lib/components/flows/content/GenAiQuick.svelte +++ b/frontend/src/lib/components/flows/content/GenAiQuick.svelte @@ -1,4 +1,5 @@ - +