mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-30 16:17:25 +00:00
feat: folder-scoped review instructions for the deployment ai review (#12037)
* feat: add ai review to deployment requests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: bound ai review fetches and surface unreadable items Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat: add fix in ai session and model picker to deployment ai review Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat: add workspace instructions for deployment ai review Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: read review instructions from the parent and bind ai review to the fork Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: pin the fix-all session preview to the fork's compare page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: show the protection-rule bypass toggle inline Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: make the bypass toggle small and red Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor: drop workspace-settings instructions from deployment ai review Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat: folder-scoped review instructions for the deployment ai review Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat: review the selected items with ai on compare and deploy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: keep reviewing when review instructions cannot be listed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: say the review instruction floor is a prompt request, not enforcement Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: mark an ai review out of date when its items change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: update ee-repo-ref to 77703cf32e58964906d87ee83ddda44b5b8d1b7e This commit updates the EE repository reference after PR #926 was merged in windmill-ee-private. Previous ee-repo-ref: e30ab9e69d1854fcaed5620c934ace32acb0a729 New ee-repo-ref: 77703cf32e58964906d87ee83ddda44b5b8d1b7e Automated by sync-ee-ref workflow. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
windmill-internal-app[bot]
parent
210a235be6
commit
62fbd508c8
@@ -50,8 +50,12 @@ Symbols, not line numbers, are cited: they drift less.
|
||||
delivered to the global chat of everyone who can read the resource, with no opt-in, whenever the
|
||||
chat touches a path under its folder (`copilot/chat/folderInstructions.ts`); the chat then acts
|
||||
with that reader's permissions, outside the folder too. `ai_skill` bodies are likewise in play
|
||||
for every reader until turned off. The resource ACL is the only control, so granting write on a
|
||||
folder grants that influence.
|
||||
for every reader until turned off. An `ai_review_instruction` steers the AI review of every
|
||||
deployment request touching its folder, for anyone who can read it in the parent workspace
|
||||
(`deploymentRequest/aiReview.ts`); a fork's own copy is never read. The prompt tells the model to
|
||||
keep reporting secrets and unintended deletions whatever they say, but that is a request to the
|
||||
model, not enforcement: an instruction body can still talk it out of them. The resource ACL is the only
|
||||
control, so granting write on a folder grants that influence.
|
||||
- **Restricted job tokens** (`job_token_scopes` on scripts and flows): a job's effective scopes
|
||||
are stored on its `job_perms` row at push and minted into its token
|
||||
(`create_token_for_owner`); an empty set is minted as `NO_API_ACCESS_SCOPE`, since
|
||||
|
||||
Reference in New Issue
Block a user