From 687fc102d5aa06049a99638201f53bb13a72de28 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Fri, 28 Oct 2022 16:11:03 +0200
Subject: [PATCH] flow ui nits

---
 .../src/lib/components/flows/common/FlowCardHeader.svelte  | 2 +-
 .../src/lib/components/flows/content/FlowInputs.svelte     | 6 +++---
 .../lib/components/flows/content/FlowModuleWrapper.svelte  | 7 +++++++
 frontend/src/lib/components/flows/map/MapItem.svelte       | 2 +-
 4 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/frontend/src/lib/components/flows/common/FlowCardHeader.svelte b/frontend/src/lib/components/flows/common/FlowCardHeader.svelte
index 467a7031f3..38e7fabf6d 100644
--- a/frontend/src/lib/components/flows/common/FlowCardHeader.svelte
+++ b/frontend/src/lib/components/flows/common/FlowCardHeader.svelte
@@ -22,7 +22,7 @@
 		<span class="text-sm w-full">
 			<div class="flex items-center space-x-2">
 				{#if shouldPick}
-					<span class="font-bold text-xs">Select a script</span>
+					<span class="font-bold text-xs">Select a step kind</span>
 				{:else if flowModule?.value.type === 'rawscript'}
 					<Badge color={languageColors[flowModule?.value.language] ?? 'gray'} capitalize>
 						{flowModule?.value.language}
diff --git a/frontend/src/lib/components/flows/content/FlowInputs.svelte b/frontend/src/lib/components/flows/content/FlowInputs.svelte
index 7852c91c40..ac4434b84f 100644
--- a/frontend/src/lib/components/flows/content/FlowInputs.svelte
+++ b/frontend/src/lib/components/flows/content/FlowInputs.svelte
@@ -78,7 +78,7 @@
 	</div>
 
 	{#if !shouldDisableTriggerScripts}
-		<div class="text-sm font-bold">
+		<div class="text-sm font-bold pt-8">
 			Trigger script
 			<Tooltip>
 				Used as a first step most commonly with an intenal state and a schedule to watch for changes
@@ -99,7 +99,7 @@
 		</div>
 	{/if}
 	{#if !failureModule}
-		<div class="text-sm font-bold">
+		<div class="text-sm font-bold pt-8">
 			Approval step
 			<Tooltip>
 				Inlined common scripts can be turned into approval step by changing their suspend settings.
@@ -123,7 +123,7 @@
 			/>
 		</div>
 
-		<div class="text-sm font-bold">Flow primitive</div>
+		<div class="text-sm font-bold pt-8">Flow primitive</div>
 
 		<div class="grid sm:grid-col-1 md:grid-col-2 lg:grid-cols-3 gap-4">
 			<FlowScriptPicker
diff --git a/frontend/src/lib/components/flows/content/FlowModuleWrapper.svelte b/frontend/src/lib/components/flows/content/FlowModuleWrapper.svelte
index 391847db79..96ae470fa1 100644
--- a/frontend/src/lib/components/flows/content/FlowModuleWrapper.svelte
+++ b/frontend/src/lib/components/flows/content/FlowModuleWrapper.svelte
@@ -17,6 +17,7 @@
 	} from '$lib/components/flows/flowStateUtils'
 	import FlowInputs from './FlowInputs.svelte'
 	import { flowStateStore, type FlowModuleState } from '../flowState'
+	import Tooltip from '$lib/components/Tooltip.svelte'
 
 	const { selectedId } = getContext<FlowEditorContext>('FlowEditorContext')
 
@@ -37,6 +38,12 @@
 	{:else if flowModule.value.type === 'branchall'}
 		<FlowBranchesWrapper {previousModuleId} bind:flowModule {parentModule} />
 	{:else if flowModule.value.type === 'identity'}
+		<h1 class="p-4"
+			>Select a step kind <Tooltip
+				>Until being defined, this step acts as an identify function, returning as result its input
+				and assigning it a key 'previous_result' if the input is not a json object</Tooltip
+			></h1
+		>
 		<FlowInputs
 			shouldDisableTriggerScripts={parentModule !== undefined || previousModuleId !== undefined}
 			on:loop={async () => {
diff --git a/frontend/src/lib/components/flows/map/MapItem.svelte b/frontend/src/lib/components/flows/map/MapItem.svelte
index 4f2deba60d..337539d54f 100644
--- a/frontend/src/lib/components/flows/map/MapItem.svelte
+++ b/frontend/src/lib/components/flows/map/MapItem.svelte
@@ -95,7 +95,7 @@
 				{...itemProps}
 				label={mod.summary ||
 					(`path` in mod.value ? mod.value.path : undefined) ||
-					(mod.value.type === 'rawscript' ? `Inline ${mod.value.language}` : 'Select a script')}
+					(mod.value.type === 'rawscript' ? `Inline ${mod.value.language}` : 'To be defined')}
 			>
 				<div slot="icon">
 					<span>{index + 1}</span>