From 6c7aba2d3e854fe79bc8fbdbc25cad248f65aed2 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Thu, 26 Jan 2023 03:20:01 +0100
Subject: [PATCH] do not copy necessarily for the flow object viewer

---
 .../lib/components/propertyPicker/ObjectViewer.svelte    | 4 ++--
 .../src/lib/components/propertyPicker/PropPicker.svelte  | 9 ++++++++-
 .../components/propertyPicker/PropPickerResult.svelte    | 2 +-
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/frontend/src/lib/components/propertyPicker/ObjectViewer.svelte b/frontend/src/lib/components/propertyPicker/ObjectViewer.svelte
index d8463379af..6c4f051e51 100644
--- a/frontend/src/lib/components/propertyPicker/ObjectViewer.svelte
+++ b/frontend/src/lib/components/propertyPicker/ObjectViewer.svelte
@@ -5,7 +5,6 @@
 	import { Badge } from '../common'
 	import { NEVER_TESTED_THIS_FAR } from '../flows/utils'
 	import { getTypeAsString } from '../flows/utils'
-	import Popover from '../Popover.svelte'
 	import { computeKey } from './utils'
 	import WarningMessage from './WarningMessage.svelte'
 
@@ -18,6 +17,7 @@
 	export let rawKey = false
 	export let topBrackets = false
 	export let topLevelNode = false
+	export let allowCopy = true
 
 	const collapsedSymbol = '...'
 	let keys: string | any[]
@@ -39,7 +39,7 @@
 	const dispatch = createEventDispatcher()
 
 	function selectProp(key: string, value: any) {
-		if (pureViewer) {
+		if (pureViewer && allowCopy) {
 			copyToClipboard(value)
 		}
 		dispatch('select', rawKey ? key : computeKey(key, isArray, currentPath))
diff --git a/frontend/src/lib/components/propertyPicker/PropPicker.svelte b/frontend/src/lib/components/propertyPicker/PropPicker.svelte
index c870babdb1..5d6ad93936 100644
--- a/frontend/src/lib/components/propertyPicker/PropPicker.svelte
+++ b/frontend/src/lib/components/propertyPicker/PropPicker.svelte
@@ -26,7 +26,7 @@
 	const EMPTY_STRING = ''
 	let search = ''
 
-	const { propPickerConfig, clearFocus } = getContext<PropPickerWrapperContext>('PropPickerWrapper')
+	const { propPickerConfig } = getContext<PropPickerWrapperContext>('PropPickerWrapper')
 
 	$: flowInputsFiltered =
 		search === EMPTY_STRING
@@ -89,6 +89,7 @@
 		</div>
 		<div class="overflow-y-auto mb-2">
 			<ObjectViewer
+				allowCopy={false}
 				pureViewer={!$propPickerConfig}
 				json={flowInputsFiltered}
 				on:select={(e) => {
@@ -100,6 +101,7 @@
 			<span class="font-bold text-sm">Error</span>
 			<div class="overflow-y-auto mb-2">
 				<ObjectViewer
+					allowCopy={false}
 					pureViewer={!$propPickerConfig}
 					json={{
 						error: {
@@ -116,6 +118,7 @@
 				<span class="font-bold text-sm">Previous Result</span>
 				<div class="overflow-y-auto mb-2">
 					<ObjectViewer
+						allowCopy={false}
 						topLevelNode
 						pureViewer={!$propPickerConfig}
 						json={Object.fromEntries(
@@ -131,6 +134,7 @@
 				<span class="font-bold text-sm">Resume payloads</span>
 				<div class="overflow-y-auto mb-2">
 					<ObjectViewer
+						allowCopy={false}
 						topLevelNode
 						pureViewer={!$propPickerConfig}
 						json={{
@@ -148,6 +152,7 @@
 				<span class="font-bold text-sm">All Results</span>
 				<div class="overflow-y-auto mb-2">
 					<ObjectViewer
+						allowCopy={false}
 						topLevelNode
 						pureViewer={!$propPickerConfig}
 						collapsed={true}
@@ -173,6 +178,7 @@
 						}}>-</Button
 					>
 					<ObjectViewer
+						allowCopy={false}
 						pureViewer={!$propPickerConfig}
 						rawKey={true}
 						json={variables}
@@ -200,6 +206,7 @@
 						}}>-</Button
 					>
 					<ObjectViewer
+						allowCopy={false}
 						pureViewer={!$propPickerConfig}
 						rawKey={true}
 						json={resources}
diff --git a/frontend/src/lib/components/propertyPicker/PropPickerResult.svelte b/frontend/src/lib/components/propertyPicker/PropPickerResult.svelte
index 00d244d461..935796d0f6 100644
--- a/frontend/src/lib/components/propertyPicker/PropPickerResult.svelte
+++ b/frontend/src/lib/components/propertyPicker/PropPickerResult.svelte
@@ -7,6 +7,6 @@
 <div class="w-full px-2">
 	<span class="font-bold text-sm">Result</span>
 	<div class="overflow-y-auto mb-2 w-full">
-		<ObjectViewer json={{ result }} on:select />
+		<ObjectViewer allowCopy={false} json={{ result }} on:select />
 	</div>
 </div>