From 6e41441b07da0bfbfce0026177e845a4fbc19d67 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Wed, 15 Nov 2023 14:38:02 +0100
Subject: [PATCH] improve empty inner loops handling

---
 backend/windmill-worker/src/worker_flow.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/backend/windmill-worker/src/worker_flow.rs b/backend/windmill-worker/src/worker_flow.rs
index b5051ecf51..db999293f2 100644
--- a/backend/windmill-worker/src/worker_flow.rs
+++ b/backend/windmill-worker/src/worker_flow.rs
@@ -398,6 +398,12 @@ pub async fn update_flow_status_after_job_completion_internal<
                     FlowStatusModule::InProgress { flow_jobs, branch_chosen, .. } => {
                         (flow_jobs.clone(), branch_chosen.clone())
                     }
+                    FlowStatusModule::Success { flow_jobs, branch_chosen, .. } => {
+                        (flow_jobs.clone(), branch_chosen.clone())
+                    }
+                    FlowStatusModule::Failure { flow_jobs, branch_chosen, .. } => {
+                        (flow_jobs.clone(), branch_chosen.clone())
+                    }
                     _ => (None, None),
                 };
                 if success || (flow_jobs.is_some() && (skip_loop_failures || skip_branch_failure)) {
@@ -1652,7 +1658,7 @@ async fn push_next_flow_job<R: rsmq_async::RsmqConnection + Send + Sync + Clone>
                                 "#,
                     )
                     .bind(status.step)
-                    .bind(json!(FlowStatusModule::Success { id: status_module.id(), job: Uuid::nil(), flow_jobs: None, branch_chosen: None, approvers: vec![] }))
+                    .bind(json!(FlowStatusModule::Success { id: status_module.id(), job: Uuid::nil(), flow_jobs: Some(vec![]), branch_chosen: None, approvers: vec![] }))
                     .bind(flow_job.id)
                     .execute(db)
                     .await?;