From 767b6fe41bd97d8484e6a8a576337c1b0836ac10 Mon Sep 17 00:00:00 2001
From: Guilhem <guilhemlemouel@gmail.com>
Date: Tue, 4 Feb 2025 19:04:28 +0000
Subject: [PATCH] clean code

---
 frontend/src/lib/components/DropdownV2Inner.svelte           | 2 +-
 .../lib/components/apps/components/display/AppMenu.svelte    | 2 --
 frontend/src/lib/components/meltComponents/MenuItem.svelte   | 5 ++++-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/frontend/src/lib/components/DropdownV2Inner.svelte b/frontend/src/lib/components/DropdownV2Inner.svelte
index 115fb8c325..f8e0548331 100644
--- a/frontend/src/lib/components/DropdownV2Inner.svelte
+++ b/frontend/src/lib/components/DropdownV2Inner.svelte
@@ -32,7 +32,7 @@
 	<div class="flex flex-col">
 		{#each computedItems ?? [] as item}
 			<MenuItem
-				on:click={(e) => item?.action?.(e)}
+				on:click={(e) => item?.action?.(e.detail)}
 				href={item?.href}
 				disabled={item?.disabled}
 				class={twMerge(
diff --git a/frontend/src/lib/components/apps/components/display/AppMenu.svelte b/frontend/src/lib/components/apps/components/display/AppMenu.svelte
index 3dae672692..de56cd22cd 100644
--- a/frontend/src/lib/components/apps/components/display/AppMenu.svelte
+++ b/frontend/src/lib/components/apps/components/display/AppMenu.svelte
@@ -35,7 +35,6 @@
 			latestButtonClicked: undefined as string | undefined
 		}
 	})
-	let menu: Menu | undefined = undefined
 
 	const resolvedConfig = initConfig(
 		components['menucomponent'].initialData.configuration,
@@ -106,7 +105,6 @@
 				on:close
 				on:open
 				class={resolvedConfig.fillContainer ? 'w-full h-full' : ''}
-				bind:this={menu}
 			>
 				<svelte:fragment slot="trigger" let:trigger>
 					<div use:melt={trigger} class="w-full h-full">
diff --git a/frontend/src/lib/components/meltComponents/MenuItem.svelte b/frontend/src/lib/components/meltComponents/MenuItem.svelte
index d0c899428e..966602e7bb 100644
--- a/frontend/src/lib/components/meltComponents/MenuItem.svelte
+++ b/frontend/src/lib/components/meltComponents/MenuItem.svelte
@@ -1,10 +1,13 @@
 <script lang="ts">
 	import { melt } from '@melt-ui/svelte'
+	import { createEventDispatcher } from 'svelte'
 
 	export let href: string | undefined = undefined
 	export let disabled: boolean = false
 
 	export let item: any
+
+	const dispatch = createEventDispatcher()
 </script>
 
 {#if href}
@@ -12,7 +15,7 @@
 		<slot />
 	</a>
 {:else}
-	<button use:melt={item} on:click {disabled} class={$$props.class}>
+	<button use:melt={item} on:click={(e) => dispatch('click', e)} {disabled} class={$$props.class}>
 		<slot />
 	</button>
 {/if}