diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6d2b05e2f2..8dec2071f2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,17 @@
# Changelog
+## [1.459.0](https://github.com/windmill-labs/windmill/compare/v1.458.4...v1.459.0) (2025-02-10)
+
+
+### Features
+
+* triggers cli sync ([#5243](https://github.com/windmill-labs/windmill/issues/5243)) ([df62925](https://github.com/windmill-labs/windmill/commit/df6292589479766acfe642d757f3736dfc369e33))
+
+
+### Bug Fixes
+
+* if user is authed, no need to use anonymous path for display result in apps ([deb1861](https://github.com/windmill-labs/windmill/commit/deb18615c20c4650e1bf765350f7abf4d2320a0a))
+
## [1.458.4](https://github.com/windmill-labs/windmill/compare/v1.458.3...v1.458.4) (2025-02-10)
diff --git a/backend/windmill-worker/src/worker_lockfiles.rs b/backend/windmill-worker/src/worker_lockfiles.rs
index 3888d8eb63..03ba19d2ad 100644
--- a/backend/windmill-worker/src/worker_lockfiles.rs
+++ b/backend/windmill-worker/src/worker_lockfiles.rs
@@ -1130,7 +1130,6 @@ async fn insert_flow_modules<'c>(
same_worker,
))
.await?;
- add_virtual_items_if_necessary(modules);
if modules.is_empty() || crate::worker_flow::is_simple_modules(modules, failure_module) {
return Ok(tx);
}
@@ -1259,6 +1258,7 @@ async fn reduce_flow<'c>(
}
module.value = to_raw_value(&val);
}
+ add_virtual_items_if_necessary(&mut *modules);
Ok(tx)
}
diff --git a/frontend/src/lib/components/DisplayResult.svelte b/frontend/src/lib/components/DisplayResult.svelte
index b5088c0a5f..80f7ce999f 100644
--- a/frontend/src/lib/components/DisplayResult.svelte
+++ b/frontend/src/lib/components/DisplayResult.svelte
@@ -677,16 +677,22 @@
{:else if result?.s3?.endsWith('.pdf')}
{/if}
diff --git a/frontend/src/lib/components/apps/components/display/AppDisplayComponent.svelte b/frontend/src/lib/components/apps/components/display/AppDisplayComponent.svelte
index 4b09156da2..c15855f873 100644
--- a/frontend/src/lib/components/apps/components/display/AppDisplayComponent.svelte
+++ b/frontend/src/lib/components/apps/components/display/AppDisplayComponent.svelte
@@ -15,6 +15,7 @@
import ResolveStyle from '../helpers/ResolveStyle.svelte'
import { components } from '../../editor/component'
import ResolveConfig from '../helpers/ResolveConfig.svelte'
+ import { userStore } from '$lib/stores'
export let id: string
export let componentInput: AppInput | undefined
@@ -96,7 +97,7 @@
{result}
{requireHtmlApproval}
disableExpand={resolvedConfig?.hideDetails}
- appPath={$appPath}
+ appPath={$userStore ? undefined : $appPath}
/>
diff --git a/frontend/src/lib/components/apps/components/display/AppDisplayComponentByJobId.svelte b/frontend/src/lib/components/apps/components/display/AppDisplayComponentByJobId.svelte
index bb5aa888d6..f61db83517 100644
--- a/frontend/src/lib/components/apps/components/display/AppDisplayComponentByJobId.svelte
+++ b/frontend/src/lib/components/apps/components/display/AppDisplayComponentByJobId.svelte
@@ -16,6 +16,7 @@
import ResolveStyle from '../helpers/ResolveStyle.svelte'
import InitializeComponent from '../helpers/InitializeComponent.svelte'
import DisplayResult from '$lib/components/DisplayResult.svelte'
+ import { userStore } from '$lib/stores'
export let id: string
export let initializing: boolean | undefined = false
@@ -23,7 +24,7 @@
export let configuration: RichConfigurations
export let render: boolean
- const { app, worldStore, workspace } = getContext('AppViewerContext')
+ const { app, worldStore, workspace, appPath } = getContext('AppViewerContext')
const requireHtmlApproval = getContext(IS_APP_PUBLIC_CONTEXT_KEY)
let resolvedConfig = initConfig(
@@ -115,6 +116,7 @@
{result}
{requireHtmlApproval}
disableExpand={resolvedConfig?.hideDetails}
+ appPath={$userStore ? undefined : $appPath}
/>
diff --git a/frontend/src/lib/components/apps/utils.ts b/frontend/src/lib/components/apps/utils.ts
index cb30aac94f..5e41d4ccfa 100644
--- a/frontend/src/lib/components/apps/utils.ts
+++ b/frontend/src/lib/components/apps/utils.ts
@@ -248,7 +248,7 @@ declare function setValue(id: string, value: any): void;
*/
declare function setSelectedIndex(id: string, index: number): void;
-/** close a drawer or modal
+/** open a drawer or modal
* @param id component's id
*/
declare function open(id: string): void;
diff --git a/frontend/src/lib/components/flows/content/FlowModuleSuspend.svelte b/frontend/src/lib/components/flows/content/FlowModuleSuspend.svelte
index 1c2ad440c6..13b0752380 100644
--- a/frontend/src/lib/components/flows/content/FlowModuleSuspend.svelte
+++ b/frontend/src/lib/components/flows/content/FlowModuleSuspend.svelte
@@ -122,8 +122,13 @@
+ {#if Boolean(flowModule.suspend?.continue_on_disapprove_timeout)}
+
+ We recommend using the expr resume?.error to handle null payload values.
+
+ To filter timeout, use resume?.error?.name === "SuspendedTimedOut".
+ To filter disapproval, use resume?.error?.name === "SuspendedDisapproved"
+
+ {/if}
{:else if suspendTabSelected === 'permissions'}
diff --git a/frontend/src/lib/components/flows/previousResults.ts b/frontend/src/lib/components/flows/previousResults.ts
index d383b30a04..9f74b62de3 100644
--- a/frontend/src/lib/components/flows/previousResults.ts
+++ b/frontend/src/lib/components/flows/previousResults.ts
@@ -88,7 +88,7 @@ function getFlowInput(
}
} else {
let parentFlowInput = getFlowInput(parentModules, flowState, args, schema)
- if (parentModule.value.type === 'forloopflow') {
+ if (parentModule.value.type === 'forloopflow' || parentModule.value.type === 'whileloopflow') {
let parentFlowInputIter = { ...parentFlowInput }
if (parentFlowInputIter.hasOwnProperty('iter')) {
parentFlowInputIter['iter_parent'] = parentFlowInputIter['iter']
@@ -263,9 +263,8 @@ declare const results = ${JSON.stringify(results)};
*/
declare const previous_result: ${previousId ? JSON.stringify(results[previousId]) : 'any'};
-${
- resume
- ? `
+${resume
+ ? `
/**
* resume payload
*/
@@ -276,8 +275,8 @@ declare const resume: any
*/
declare const approvers: string
`
- : ''
-}
+ : ''
+ }
`
}
diff --git a/version.txt b/version.txt
index dcd4fcaeb2..d22eaab6f1 100644
--- a/version.txt
+++ b/version.txt
@@ -1 +1 @@
-1.458.4
+1.459.0