starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-08 16:03:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: refuse a dbt:// subscription that is not a whole relation

Browse Source 
`# on dbt://main/analytics` deployed and persisted a trigger row. Every producer
spells `<warehouse>/<schema>/<name>` — the manifest ingest derives it from
`relation_name`, a `// materialize` target is checked against it — so a partial
one is an edge nothing can ever wake, which is what the dbt-only refusal exists
to prevent.

The shape now has one definition (`is_full_relation_path`) that both halves of
the deploy ask, rather than a segment count spelled twice: a subscription and a
write that disagreed would refuse and accept the same string.

Also rewrites the canvas test's comment as a current constraint per AGENTS.md.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-09-05 04:34:19 +02:00
co-authored by Claude Opus 5
parent dff574d3d9
commit 7b3c545ce3
4 changed files with 51 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-api-scripts/src/scripts.rs
+14 -6
View File
@@ -1638,25 +1638,24 @@ async fn create_script_internal<'c>(
.to_string(),
));
}
let segments = m.target_path.split('/').collect::<Vec<_>>();
if segments.len() != 3 || segments.iter().any(|s| s.is_empty()) {
if !windmill_parser::asset_parser::is_full_relation_path(&m.target_path) {
return Err(Error::BadRequest(format!(
"`// materialize` needs a full warehouse relation in the target: \
`dbt://<warehouse>/<schema>/<name>` (got `dbt://{}`).",
m.target_path
)));
}
let warehouse = m.target_path.split('/').next().unwrap_or_default();
// The warehouse segment IS the identity a dbt model reading this
// relation keys on, so a name no warehouse answers to is not a
// namespace — it strands this write on a node nothing reaches.
// Same resolution a dbt descriptor's `profile.warehouse` gets.
windmill_common::workspaces::dbt_warehouse_exists(&db, &w_id, segments[0])
windmill_common::workspaces::dbt_warehouse_exists(&db, &w_id, warehouse)
.await
.map_err(|e| {
Error::BadRequest(format!(
"`// materialize dbt://{}/…` names a warehouse this workspace does \
not configure: {e}",
segments[0]
"`// materialize dbt://{warehouse}/…` names a warehouse this \
workspace does not configure: {e}"
))
})?;
}
@@ -2468,6 +2467,15 @@ async fn create_script_internal<'c>(
and a project is run on its schedule, not woken by an asset cascade."
)));
}
// Every producer spells a whole relation, so a partial one is an edge
// nothing can ever wake — refused on the same terms as the dbt-only
// case rather than persisted.
if !windmill_parser::asset_parser::is_full_relation_path(relation) {
return Err(Error::BadRequest(format!(
"`{trigger_ref}` is not a whole warehouse relation \
(`dbt://<warehouse>/<schema>/<name>`), so nothing can produce it."
)));
}
// Both paths under a rename: the old one's committed write row is
// still there and this transaction is about to remove it.
let deploying_paths = match p_path_opt.as_deref().filter(|old| *old != ns.path) {