From 7d6868a0cbaeb93fc096bbccc70ac9cd6c3bec2b Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Wed, 5 Jun 2024 15:49:21 +0200
Subject: [PATCH] increase token length to 32 chars

---
 backend/windmill-api/src/users.rs     | 6 +++---
 backend/windmill-worker/src/worker.rs | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/backend/windmill-api/src/users.rs b/backend/windmill-api/src/users.rs
index b5f55079e3..0e1d6c691a 100644
--- a/backend/windmill-api/src/users.rs
+++ b/backend/windmill-api/src/users.rs
@@ -2206,7 +2206,7 @@ pub async fn create_session_token<'c>(
     tx: &mut sqlx::Transaction<'c, sqlx::Postgres>,
     cookies: Cookies,
 ) -> Result<String> {
-    let token = rd_string(30);
+    let token = rd_string(32);
     sqlx::query!(
         "INSERT INTO token
             (token, email, label, expiration, super_admin)
@@ -2239,7 +2239,7 @@ async fn create_token(
     authed: ApiAuthed,
     Json(new_token): Json<NewToken>,
 ) -> Result<(StatusCode, String)> {
-    let token = rd_string(30);
+    let token = rd_string(32);
     let mut tx = db.begin().await?;
 
     let is_super_admin = sqlx::query_scalar!(
@@ -2283,7 +2283,7 @@ async fn impersonate(
     authed: ApiAuthed,
     Json(new_token): Json<NewToken>,
 ) -> Result<(StatusCode, String)> {
-    let token = rd_string(30);
+    let token = rd_string(32);
     require_super_admin(&db, &authed.email).await?;
 
     if new_token.impersonate_email.is_none() {
diff --git a/backend/windmill-worker/src/worker.rs b/backend/windmill-worker/src/worker.rs
index 3a4077a0b8..56ee0c3298 100644
--- a/backend/windmill-worker/src/worker.rs
+++ b/backend/windmill-worker/src/worker.rs
@@ -168,7 +168,7 @@ pub async fn create_token_for_owner(
         return Ok(token.clone());
     }
 
-    let token: String = rd_string(30);
+    let token: String = rd_string(32);
     let is_super_admin =
         sqlx::query_scalar!("SELECT super_admin FROM password WHERE email = $1", email)
             .fetch_optional(db)
@@ -2218,7 +2218,7 @@ async fn spawn_dedicated_worker(
             let token = if let Some(token) = JOB_TOKEN.as_ref() {
                 token.clone()
             } else {
-                let token = rd_string(30);
+                let token = rd_string(32);
                 if let Err(e) = sqlx::query_scalar!(
                     "INSERT INTO token
                     (token, label, super_admin, email)