From 81ff0dcd8cc2fb1c5fc12a558702cbc950ca1eb4 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Sat, 20 Sep 2025 13:41:15 +0000
Subject: [PATCH] fix: retry python relative imports on errno 104

---
 backend/windmill-worker/loader.py           | 45 ++++++++++++---------
 frontend/src/lib/components/ArgInput.svelte |  2 +-
 2 files changed, 27 insertions(+), 20 deletions(-)

diff --git a/backend/windmill-worker/loader.py b/backend/windmill-worker/loader.py
index 1361e06ead..c387e5e0fc 100644
--- a/backend/windmill-worker/loader.py
+++ b/backend/windmill-worker/loader.py
@@ -51,25 +51,32 @@ class WindmillFinder(MetaPathFinder):
             url = f"{os.environ.get('BASE_INTERNAL_URL')}/api/w/{os.environ.get('WM_WORKSPACE')}/scripts/raw/p/{script_path}.py{query_params}"
 
             req = urllib.request.Request(url, None, headers)
-            try:
-                req_start = time.time()
-                with urllib.request.urlopen(req) as response:
-                    os.makedirs(folder, exist_ok=True)
-                    r = response.read().decode("utf-8")
-                    if r == "WINDMILL_IS_FOLDER":
-                        return ModuleSpec(name, WindmillLoader(name))
-                    with open(fullpath, "w+") as f:
-                        f.write(r)
-                    return ModuleSpec(name, SourceFileLoader(name, fullpath))
-            except urllib.error.HTTPError as e:
-                duration = time.time() - req_start
-                if e.code != 404:
-                    print(f"Error fetching script {script_path}: HTTP {e.code} - {e.reason} - {duration}s")
-                return ModuleSpec(name, WindmillLoader(name))
-            except Exception as e:
-                duration = time.time() - req_start
-                print(f"Error fetching script {script_path}: {e} - {duration}s")
-                return ModuleSpec(name, WindmillLoader(name))
+            
+            for attempt in range(4):  # 0, 1, 2, 3 = up to 3 retries
+                try:
+                    req_start = time.time()
+                    with urllib.request.urlopen(req) as response:
+                        os.makedirs(folder, exist_ok=True)
+                        r = response.read().decode("utf-8")
+                        if r == "WINDMILL_IS_FOLDER":
+                            return ModuleSpec(name, WindmillLoader(name))
+                        with open(fullpath, "w+") as f:
+                            f.write(r)
+                        return ModuleSpec(name, SourceFileLoader(name, fullpath))
+                except urllib.error.HTTPError as e:
+                    duration = time.time() - req_start
+                    if e.code != 404:
+                        print(f"Error fetching script {script_path}: HTTP {e.code} - {e.reason} - {duration}s")
+                    return ModuleSpec(name, WindmillLoader(name))
+                except Exception as e:
+                    duration = time.time() - req_start
+                    # Check if this is errno 104 (Connection reset by peer) and we have retries left
+                    if (hasattr(e, 'errno') and e.errno == 104) and attempt < 3:
+                        print(f"Connection reset (errno 104) fetching script {script_path}, retrying in 3s (attempt {attempt + 1}/3)")
+                        time.sleep(3)
+                        continue
+                    print(f"Error fetching script {script_path}: {e} - {duration}s")
+                    return ModuleSpec(name, WindmillLoader(name))
 
 
 
diff --git a/frontend/src/lib/components/ArgInput.svelte b/frontend/src/lib/components/ArgInput.svelte
index 711e615e09..6df54a8054 100644
--- a/frontend/src/lib/components/ArgInput.svelte
+++ b/frontend/src/lib/components/ArgInput.svelte
@@ -1338,7 +1338,7 @@
 						<!-- svelte-ignore a11y_click_events_have_key_events -->
 						<button
 							class="absolute {password || extra?.['password'] == true
-								? 'right-16 top-1.5 '
+								? 'right-16 top-1.5'
 								: 'right-1 top-1'} opacity-0 group-hover:opacity-100 duration-200 py-1 min-w-min !px-2 items-center text-gray-800 bg-surface-secondary border rounded center-center hover:bg-gray-300 transition-all cursor-pointer"
 							onclick={() => {
 								pickForField = label