From 85e6e83236a49aaea88e168a922451a28e5d14ff Mon Sep 17 00:00:00 2001 From: centdix Date: Fri, 27 Mar 2026 12:54:16 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20address=20PR=20review=20=E2=80=94=20work?= =?UTF-8?q?space=20prop,=20length=20check,=20empty=20folder=20state?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 4.6 (1M context) --- .../src/lib/components/mcp/McpScopeSelector.svelte | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/frontend/src/lib/components/mcp/McpScopeSelector.svelte b/frontend/src/lib/components/mcp/McpScopeSelector.svelte index f91091ea4c..c0a96dd151 100644 --- a/frontend/src/lib/components/mcp/McpScopeSelector.svelte +++ b/frontend/src/lib/components/mcp/McpScopeSelector.svelte @@ -7,7 +7,6 @@ import { safeSelectItems } from '$lib/components/select/utils.svelte' import TextInput from '$lib/components/text_input/TextInput.svelte' import { FlowService, FolderService, IntegrationService, ScriptService } from '$lib/gen' - import { workspaceStore } from '$lib/stores' import { mcpEndpointTools } from '$lib/mcpEndpointTools' import InfoIcon from 'lucide-svelte/icons/info' import { SvelteMap } from 'svelte/reactivity' @@ -73,7 +72,7 @@ } } else if (selectedMode === 'folder') { const folderPaths = selectedFolders.map((f) => `f/${f}/*`).join(',') - if (folderPaths.length > 0) { + if (selectedFolders.length > 0) { scopeParts = [`mcp:scripts:${folderPaths}`, `mcp:flows:${folderPaths}`, `mcp:endpoints:*`] } } else { @@ -111,7 +110,7 @@ const excludedFolders = ['app_groups', 'app_custom', 'app_themes'] allFolders = ( await FolderService.listFolderNames({ - workspace: $workspaceStore! + workspace: workspaceId }) ).filter((x) => !excludedFolders.includes(x)) } catch { @@ -215,8 +214,12 @@ // Load runnables based on mode $effect(() => { if (workspaceId) { - if (selectedMode === 'folder' && selectedFolders.length > 0) { - loadRunnablesForFolders(workspaceId, selectedFolders) + if (selectedMode === 'folder') { + if (selectedFolders.length > 0) { + loadRunnablesForFolders(workspaceId, selectedFolders) + } else { + includedRunnables = [] + } } else { getScriptsAndFlows(selectedMode === 'favorites', workspaceId, undefined) }