From 8e1e37bf9e941dcbc43d99f3f86ceda68d70de14 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Mon, 3 Mar 2025 14:58:49 +0100
Subject: [PATCH] improve menu a hrefs

---
 frontend/src/lib/components/meltComponents/Menu.svelte   | 2 +-
 .../src/lib/components/meltComponents/MenuItem.svelte    | 9 ---------
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/frontend/src/lib/components/meltComponents/Menu.svelte b/frontend/src/lib/components/meltComponents/Menu.svelte
index 295b973df2..0e459033f0 100644
--- a/frontend/src/lib/components/meltComponents/Menu.svelte
+++ b/frontend/src/lib/components/meltComponents/Menu.svelte
@@ -68,7 +68,7 @@
 
 	<!--svelte-ignore a11y-no-static-element-interactions-->
 	{#if open}
-		<div use:melt={$menuElement} data-menu class="z-[6000]" on:click|stopPropagation>
+		<div use:melt={$menuElement} data-menu class="z-[6000]" on:click>
 			<div
 				class={twMerge(
 					'border w-56 origin-top-right rounded-md shadow-md focus:outline-none overflow-y-auto py-1',
diff --git a/frontend/src/lib/components/meltComponents/MenuItem.svelte b/frontend/src/lib/components/meltComponents/MenuItem.svelte
index 8855f63fbe..2edcd755ae 100644
--- a/frontend/src/lib/components/meltComponents/MenuItem.svelte
+++ b/frontend/src/lib/components/meltComponents/MenuItem.svelte
@@ -1,19 +1,11 @@
 <script lang="ts">
 	import { melt } from '@melt-ui/svelte'
 	import type { MenubarMenuElements } from '@melt-ui/svelte'
-	import { goto } from '$app/navigation'
 
 	export let href: string | undefined = undefined
 	export let disabled: boolean = false
 	export let target: string | undefined = undefined
 	export let item: MenubarMenuElements['item']
-
-	function handleClick(e: MouseEvent) {
-		if (href && !target) {
-			e.preventDefault()
-			goto(href)
-		}
-	}
 </script>
 
 {#if href}
@@ -25,7 +17,6 @@
 		aria-disabled={disabled}
 		tabindex={disabled ? -1 : undefined}
 		{target}
-		on:click={handleClick}
 		on:m-focusin
 		on:m-focusout
 	>