From 8fd0e23c803bc033d52d4b2bf369f0622f4690c5 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Sun, 6 Nov 2022 16:08:10 +0100 Subject: [PATCH] UX improvements for run script --- backend/windmill-api/src/scripts.rs | 4 +- .../lib/components/ButtonAndDropdown.svelte | 2 +- frontend/src/lib/components/Dropdown.svelte | 9 +- .../src/lib/components/FlowBuilder.svelte | 2 +- frontend/src/lib/components/FlowViewer.svelte | 8 +- frontend/src/lib/components/RunForm.svelte | 97 ++- frontend/src/lib/components/ShareModal.svelte | 6 +- .../common/actionRow/ActionRow.svelte | 6 +- .../lib/components/landing/ScriptBox.svelte | 2 +- frontend/src/lib/utils.ts | 6 +- frontend/src/routes/__layout@root.svelte | 16 +- .../src/routes/flows/get/[...path].svelte | 358 +++++------ .../src/routes/flows/run/[...path].svelte | 89 ++- frontend/src/routes/run/[...run].svelte | 40 +- .../src/routes/scripts/get/[...hash].svelte | 599 +++++++++--------- .../src/routes/scripts/run/[...hash].svelte | 111 +++- 16 files changed, 790 insertions(+), 565 deletions(-) diff --git a/backend/windmill-api/src/scripts.rs b/backend/windmill-api/src/scripts.rs index bf2333ef5b..a7e7a78a02 100644 --- a/backend/windmill-api/src/scripts.rs +++ b/backend/windmill-api/src/scripts.rs @@ -621,8 +621,8 @@ async fn delete_script_by_hash( require_admin(authed.is_admin, &authed.username)?; let script = sqlx::query_as::<_, Script>( - "UPDATE script SET content = '', archived = true, deleted = true WHERE hash = $1 AND \ - workspace_id = $2RETURNING *", + "UPDATE script SET content = '', archived = true, deleted = true, lock = '', schema = null WHERE hash = $1 AND \ + workspace_id = $2 RETURNING *", ) .bind(&hash.0) .bind(&w_id) diff --git a/frontend/src/lib/components/ButtonAndDropdown.svelte b/frontend/src/lib/components/ButtonAndDropdown.svelte index 05349ab68f..efb7a88129 100644 --- a/frontend/src/lib/components/ButtonAndDropdown.svelte +++ b/frontend/src/lib/components/ButtonAndDropdown.svelte @@ -22,7 +22,7 @@ class="border-l border-gray-300 px-2 inline-block py-0 my-0" on:click={() => dispatch('clickDropdown')} > -
+
diff --git a/frontend/src/lib/components/Dropdown.svelte b/frontend/src/lib/components/Dropdown.svelte index 816cdf6c9e..961603036d 100644 --- a/frontend/src/lib/components/Dropdown.svelte +++ b/frontend/src/lib/components/Dropdown.svelte @@ -15,6 +15,7 @@ // This can cause the dropdown to be hidden if it is in an overflow-hidden div. // In that case, set relative to false and control the dropdown positioning from the div export let relative = true + export let left = true const dispatch = createEventDispatcher() @@ -33,14 +34,16 @@ on:click_outside={handleClickOutsideMenu} >