From 96f5378e7291ce42b2a6cbfc7041361c0d6db044 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Fri, 31 Jan 2025 09:26:29 +0100
Subject: [PATCH] only mask passwords in more places

---
 frontend/src/lib/components/FlowStatusWaitingForEvents.svelte   | 2 +-
 frontend/src/lib/components/RunPageSchedules.svelte             | 2 +-
 .../components/apps/components/display/dbtable/InsertRow.svelte | 2 +-
 .../components/apps/components/helpers/RunnableComponent.svelte | 1 +
 .../src/lib/components/apps/editor/AppReportsDrawerInner.svelte | 1 +
 5 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/frontend/src/lib/components/FlowStatusWaitingForEvents.svelte b/frontend/src/lib/components/FlowStatusWaitingForEvents.svelte
index 49de5fc21d..2e9bf984b4 100644
--- a/frontend/src/lib/components/FlowStatusWaitingForEvents.svelte
+++ b/frontend/src/lib/components/FlowStatusWaitingForEvents.svelte
@@ -145,7 +145,7 @@
 
 				{#if job?.raw_flow?.modules?.[approvalStep]?.suspend?.resume_form?.schema}
 					<div class="w-full border rounded-lg p-2">
-						<SchemaForm bind:args={default_payload} {defaultValues} {schema} />
+						<SchemaForm onlyMaskPassword bind:args={default_payload} {defaultValues} {schema} />
 					</div>
 				{/if}
 				<Tooltip
diff --git a/frontend/src/lib/components/RunPageSchedules.svelte b/frontend/src/lib/components/RunPageSchedules.svelte
index 1de92911a3..4b721fd8a5 100644
--- a/frontend/src/lib/components/RunPageSchedules.svelte
+++ b/frontend/src/lib/components/RunPageSchedules.svelte
@@ -136,7 +136,7 @@
 			</div>
 		</div>
 		<CronInput bind:schedule={$primarySchedule.cron} bind:timezone={$primarySchedule.timezone} />
-		<SchemaForm {schema} bind:args={$primarySchedule.args} />
+		<SchemaForm onlyMaskPassword {schema} bind:args={$primarySchedule.args} />
 		{#if emptyString($primarySchedule.cron)}
 			<p class="text-xs text-tertiary mt-10">Define a schedule frequency first</p>
 		{/if}
diff --git a/frontend/src/lib/components/apps/components/display/dbtable/InsertRow.svelte b/frontend/src/lib/components/apps/components/display/dbtable/InsertRow.svelte
index 7ccbfb9373..70102962df 100644
--- a/frontend/src/lib/components/apps/components/display/dbtable/InsertRow.svelte
+++ b/frontend/src/lib/components/apps/components/display/dbtable/InsertRow.svelte
@@ -156,5 +156,5 @@
 </script>
 
 {#if schema}
-	<SchemaForm {schema} bind:args />
+	<SchemaForm onlyMaskPassword {schema} bind:args />
 {/if}
diff --git a/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte b/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte
index a5d4e42ee5..5303f90267 100644
--- a/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte
+++ b/frontend/src/lib/components/apps/components/helpers/RunnableComponent.svelte
@@ -769,6 +769,7 @@
 		{#if render && (autoRefresh || forceSchemaDisplay) && schemaStripped && Object.keys(schemaStripped?.properties ?? {}).length > 0}
 			<div class="px-2 h-fit min-h-0">
 				<SchemaForm
+					onlyMaskPassword
 					schema={schemaStripped}
 					appPath={defaultIfEmptyString($appPath, `u/${$userStore?.username ?? 'unknown'}/newapp`)}
 					{computeS3ForceViewerPolicies}
diff --git a/frontend/src/lib/components/apps/editor/AppReportsDrawerInner.svelte b/frontend/src/lib/components/apps/editor/AppReportsDrawerInner.svelte
index b05e0ef9b4..9f77b72279 100644
--- a/frontend/src/lib/components/apps/editor/AppReportsDrawerInner.svelte
+++ b/frontend/src/lib/components/apps/editor/AppReportsDrawerInner.svelte
@@ -650,6 +650,7 @@ export async function main(app_path: string, startup_duration = 5, kind: 'pdf' |
 				{#if selectedTab !== 'custom' || customPath !== undefined}
 					{#key selectedTab + JSON.stringify(customPathSchema ?? {})}
 						<SchemaForm
+							onlyMaskPassword
 							bind:isValid={areArgsValid}
 							bind:args
 							schema={selectedTab !== 'custom'