From 987990ee41c45b75f17bd30e5ce60a96da8c9c09 Mon Sep 17 00:00:00 2001
From: Guilhem <guilhemlemouel@gmail.com>
Date: Mon, 10 Feb 2025 15:26:03 +0000
Subject: [PATCH] use pointerdown in menus

---
 frontend/src/lib/components/flows/map/FlowJobsMenu.svelte | 2 +-
 frontend/src/lib/components/meltComponents/Menu.svelte    | 1 -
 frontend/src/lib/components/sidebar/FavoriteMenu.svelte   | 2 +-
 frontend/src/lib/components/sidebar/OperatorMenu.svelte   | 2 +-
 frontend/src/lib/components/sidebar/SidebarContent.svelte | 6 +++---
 frontend/src/lib/components/sidebar/UserMenu.svelte       | 2 +-
 frontend/src/lib/components/sidebar/WorkspaceMenu.svelte  | 2 +-
 7 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/frontend/src/lib/components/flows/map/FlowJobsMenu.svelte b/frontend/src/lib/components/flows/map/FlowJobsMenu.svelte
index b709d9e47b..97156f4149 100644
--- a/frontend/src/lib/components/flows/map/FlowJobsMenu.svelte
+++ b/frontend/src/lib/components/flows/map/FlowJobsMenu.svelte
@@ -62,7 +62,7 @@
 {/if}
 
 <Menubar let:createMenu>
-	<Menu {createMenu} let:item placement="bottom" bind:this={menu}>
+	<Menu {createMenu} let:item placement="bottom" bind:this={menu} usePointerDownOutside>
 		<svelte:fragment slot="trigger" let:trigger>
 			<button
 				title="Pick an iteration"
diff --git a/frontend/src/lib/components/meltComponents/Menu.svelte b/frontend/src/lib/components/meltComponents/Menu.svelte
index 82ca93ba1a..cb609ecce5 100644
--- a/frontend/src/lib/components/meltComponents/Menu.svelte
+++ b/frontend/src/lib/components/meltComponents/Menu.svelte
@@ -57,7 +57,6 @@
 			customEventName: 'pointerdown_menu'
 		}}
 		on:pointerdown_outside={() => {
-			console.log('dbg pointer down menu outside')
 			if (usePointerDownOutside) {
 				close()
 			}
diff --git a/frontend/src/lib/components/sidebar/FavoriteMenu.svelte b/frontend/src/lib/components/sidebar/FavoriteMenu.svelte
index 7cfe30f3a8..c96a8c0071 100644
--- a/frontend/src/lib/components/sidebar/FavoriteMenu.svelte
+++ b/frontend/src/lib/components/sidebar/FavoriteMenu.svelte
@@ -15,7 +15,7 @@
 	export let createMenu: any
 </script>
 
-<Menu {createMenu} let:item>
+<Menu {createMenu} let:item usePointerDownOutside>
 	<svelte:fragment slot="trigger" let:trigger>
 		<MenuButtonMelt
 			class="!text-xs"
diff --git a/frontend/src/lib/components/sidebar/OperatorMenu.svelte b/frontend/src/lib/components/sidebar/OperatorMenu.svelte
index b6f62e6039..91e4aa6553 100644
--- a/frontend/src/lib/components/sidebar/OperatorMenu.svelte
+++ b/frontend/src/lib/components/sidebar/OperatorMenu.svelte
@@ -115,7 +115,7 @@
 </script>
 
 <Menubar let:createMenu>
-	<Menu {createMenu} let:item>
+	<Menu {createMenu} let:item usePointerDownOutside>
 		<svelte:fragment slot="trigger" let:trigger>
 			<MenuButtonMelt
 				class="!text-xs"
diff --git a/frontend/src/lib/components/sidebar/SidebarContent.svelte b/frontend/src/lib/components/sidebar/SidebarContent.svelte
index b3d969a62b..115276055d 100644
--- a/frontend/src/lib/components/sidebar/SidebarContent.svelte
+++ b/frontend/src/lib/components/sidebar/SidebarContent.svelte
@@ -326,7 +326,7 @@
 						<MenuLink class="!text-xs" {...menuLink} {isCollapsed} />
 					{/each}
 					{#if extraTriggerLinks.length > 0 && !$userStore?.operator}
-						<Menu {createMenu} let:item>
+						<Menu {createMenu} let:item usePointerDownOutside>
 							<svelte:fragment slot="trigger" let:trigger>
 								<div
 									slot="trigger"
@@ -377,7 +377,7 @@
 				{#each secondaryMenuLinks as menuLink (menuLink.href ?? menuLink.label)}
 					{#if menuLink.subItems}
 						{@const notificationsCount = computeAllNotificationsCount(menuLink.subItems)}
-						<Menu {createMenu} let:item>
+						<Menu {createMenu} let:item usePointerDownOutside>
 							<svelte:fragment slot="trigger" let:trigger>
 								<MenuButtonMelt
 									class="!text-2xs"
@@ -465,7 +465,7 @@
 			<Menubar let:createMenu>
 				{#each thirdMenuLinks as menuLink (menuLink)}
 					{#if menuLink.subItems}
-						<Menu {createMenu} let:item>
+						<Menu {createMenu} let:item usePointerDownOutside>
 							<svelte:fragment slot="trigger" let:trigger>
 								<button
 									class="relative w-full"
diff --git a/frontend/src/lib/components/sidebar/UserMenu.svelte b/frontend/src/lib/components/sidebar/UserMenu.svelte
index c27bb73ac4..326ddf8641 100644
--- a/frontend/src/lib/components/sidebar/UserMenu.svelte
+++ b/frontend/src/lib/components/sidebar/UserMenu.svelte
@@ -23,7 +23,7 @@
 	export let createMenu: (any) => any
 </script>
 
-<Menu {createMenu} let:item>
+<Menu {createMenu} let:item usePointerDownOutside>
 	<svelte:fragment slot="trigger" let:trigger>
 		<MenuButtonMelt
 			class="!text-xs"
diff --git a/frontend/src/lib/components/sidebar/WorkspaceMenu.svelte b/frontend/src/lib/components/sidebar/WorkspaceMenu.svelte
index 6053b1ee3a..0735f30f1b 100644
--- a/frontend/src/lib/components/sidebar/WorkspaceMenu.svelte
+++ b/frontend/src/lib/components/sidebar/WorkspaceMenu.svelte
@@ -54,7 +54,7 @@
 	}
 </script>
 
-<Menu {createMenu} let:item>
+<Menu {createMenu} let:item usePointerDownOutside>
 	<svelte:fragment slot="trigger" let:trigger>
 		<MenuButtonMelt
 			class="!text-xs"