From 99bb6ce775ccf2441d0aa4d77d40f8025c211688 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Thu, 24 Nov 2022 10:18:29 +0100
Subject: [PATCH] no error message on canceling a completed job

---
 backend/windmill-api/src/jobs.rs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/backend/windmill-api/src/jobs.rs b/backend/windmill-api/src/jobs.rs
index ceaa17fc94..1ddbe225d7 100644
--- a/backend/windmill-api/src/jobs.rs
+++ b/backend/windmill-api/src/jobs.rs
@@ -128,10 +128,9 @@ async fn cancel_job_api(
         let (job_o, tx) = get_job_by_id(tx, &w_id, id).await?;
         tx.commit().await?;
         let err = match job_o {
-            Some(Job::CompletedJob(_)) => error::Error::BadRequest(format!(
-                "queued job id {} exists but is already completed and cannot be canceled",
-                id
-            )),
+            Some(Job::CompletedJob(_)) => {
+                return Ok(format!("queued job id {} is already completed", id))
+            }
             _ => error::Error::NotFound(format!("queued job id {} does not exist", id)),
         };
         Err(err)