From 9e897dd693dec728bb5333d6904a47b0d3e1a951 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Mon, 17 Nov 2025 23:26:47 +0100 Subject: [PATCH] fix: fix custom email triggers enabled (#7164) --- backend/migrations/20251117222148_email_enabled.down.sql | 1 + backend/migrations/20251117222148_email_enabled.up.sql | 3 +++ backend/windmill-api/src/triggers/email/handler_oss.rs | 2 +- backend/windmill-api/src/triggers/handler.rs | 1 + 4 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 backend/migrations/20251117222148_email_enabled.down.sql create mode 100644 backend/migrations/20251117222148_email_enabled.up.sql diff --git a/backend/migrations/20251117222148_email_enabled.down.sql b/backend/migrations/20251117222148_email_enabled.down.sql new file mode 100644 index 0000000000..d2f607c5b8 --- /dev/null +++ b/backend/migrations/20251117222148_email_enabled.down.sql @@ -0,0 +1 @@ +-- Add down migration script here diff --git a/backend/migrations/20251117222148_email_enabled.up.sql b/backend/migrations/20251117222148_email_enabled.up.sql new file mode 100644 index 0000000000..861d171af9 --- /dev/null +++ b/backend/migrations/20251117222148_email_enabled.up.sql @@ -0,0 +1,3 @@ +-- Add up migration script here + +ALTER TABLE email_trigger ADD COLUMN enabled BOOLEAN DEFAULT TRUE NOT NULL; \ No newline at end of file diff --git a/backend/windmill-api/src/triggers/email/handler_oss.rs b/backend/windmill-api/src/triggers/email/handler_oss.rs index 2f3a318bdd..ca4de1733e 100644 --- a/backend/windmill-api/src/triggers/email/handler_oss.rs +++ b/backend/windmill-api/src/triggers/email/handler_oss.rs @@ -28,7 +28,7 @@ impl TriggerCrud for EmailTrigger { const TABLE_NAME: &'static str = ""; const TRIGGER_TYPE: &'static str = ""; - const SUPPORTS_ENABLED: bool = false; + const SUPPORTS_ENABLED: bool = true; const SUPPORTS_SERVER_STATE: bool = false; const SUPPORTS_TEST_CONNECTION: bool = false; const ROUTE_PREFIX: &'static str = "/email_triggers"; diff --git a/backend/windmill-api/src/triggers/handler.rs b/backend/windmill-api/src/triggers/handler.rs index 66851aed9e..a6019c5a14 100644 --- a/backend/windmill-api/src/triggers/handler.rs +++ b/backend/windmill-api/src/triggers/handler.rs @@ -366,6 +366,7 @@ pub trait TriggerCrud: Send + Sync + 'static { .sql() .map_err(|e| Error::InternalErr(format!("SQL error: {}", e)))?; + tracing::info!("SQL: {}", sql); let triggers = sqlx::query_as(&sql).fetch_all(&mut *tx).await?; Ok(triggers)