From a658167043e3c900d94daa03cb8fb2e6ac93e01c Mon Sep 17 00:00:00 2001
From: Diego Imbert <diego@windmill.dev>
Date: Thu, 3 Jul 2025 12:18:02 +0200
Subject: [PATCH] remove mini toggle button group, use ToggleButtonGroup

---
 .../components/MiniToggleButtonGroup.svelte   | 80 -------------------
 .../assets/AssetsDropdownButton.svelte        | 20 ++---
 2 files changed, 11 insertions(+), 89 deletions(-)
 delete mode 100644 frontend/src/lib/components/MiniToggleButtonGroup.svelte

diff --git a/frontend/src/lib/components/MiniToggleButtonGroup.svelte b/frontend/src/lib/components/MiniToggleButtonGroup.svelte
deleted file mode 100644
index 89c48ea347..0000000000
--- a/frontend/src/lib/components/MiniToggleButtonGroup.svelte
+++ /dev/null
@@ -1,80 +0,0 @@
-<!-- A component similar to Toggle but with more than two values -->
-<script lang="ts" generics="T">
-	import { twMerge } from 'tailwind-merge'
-	import { getLabel } from './select/utils.svelte'
-	import { fade } from 'svelte/transition'
-
-	let {
-		items,
-		value = $bindable(),
-		class: className,
-		error,
-		disabled,
-		clearable = false
-	}: {
-		items: { label?: string; value: T }[]
-		value: T
-		class?: string
-		error?: boolean
-		disabled?: boolean
-		clearable?: boolean
-	} = $props()
-
-	let btnRefs = $state<Record<number, HTMLButtonElement | undefined>>({})
-	let btnWidths: { w: number; offsetX: number }[] = $state([])
-	$effect(() => {
-		btnRefs
-		for (const item of items) {
-			item.label
-			item.value
-		}
-		setTimeout(() => {
-			btnWidths = []
-			for (let i = 0; i in btnRefs; i++) {
-				btnWidths.push({
-					w: btnRefs[i]?.getBoundingClientRect().width ?? 0,
-					offsetX: btnRefs[i]?.offsetLeft ?? 0
-				})
-			}
-		}, 0)
-	})
-	let selectedIdx = $derived(items.findIndex((item) => item.value === value))
-	let selectedBtnBox: (typeof btnWidths)[number] | undefined = $derived(btnWidths[selectedIdx])
-</script>
-
-<ul
-	class={twMerge(
-		'flex text-nowrap px-[1px] bg-gray-300 rounded-full items-center border relative transition-colors',
-		error ? 'border-red-300 bg-red-100' : '',
-		className
-	)}
->
-	<!-- White animated selector -->
-	{#if selectedBtnBox}
-		<div
-			class={twMerge('h-[22px] bg-white rounded-full absolute transition-all')}
-			transition:fade={{ duration: 120 }}
-			style={`width: ${selectedBtnBox?.w ?? 22}px; left: ${selectedBtnBox?.offsetX ?? 0}px;`}
-		></div>
-	{/if}
-
-	{#each items as item, i}
-		<li class="h-6 text-xs flex items-center">
-			<button
-				bind:this={btnRefs[i]}
-				class="z-10 rounded-full px-1.5 h-6 min-w-6 flex items-center justify-center"
-				{disabled}
-				onclick={() => {
-					if (disabled) return
-					if (clearable && value === item.value) {
-						value = undefined as any
-					} else {
-						value = item.value
-					}
-				}}
-			>
-				{getLabel(item)}
-			</button>
-		</li>
-	{/each}
-</ul>
diff --git a/frontend/src/lib/components/assets/AssetsDropdownButton.svelte b/frontend/src/lib/components/assets/AssetsDropdownButton.svelte
index a07197c038..80f06bd094 100644
--- a/frontend/src/lib/components/assets/AssetsDropdownButton.svelte
+++ b/frontend/src/lib/components/assets/AssetsDropdownButton.svelte
@@ -17,8 +17,8 @@
 	import Tooltip from '../meltComponents/Tooltip.svelte'
 	import ResourceEditorDrawer from '../ResourceEditorDrawer.svelte'
 	import type { Placement } from '@floating-ui/core'
-	import { safeSelectItems } from '../select/utils.svelte'
-	import MiniToggleButtonGroup from '../MiniToggleButtonGroup.svelte'
+	import ToggleButtonGroup from '../common/toggleButton-v2/ToggleButtonGroup.svelte'
+	import ToggleButton from '../common/toggleButton-v2/ToggleButton.svelte'
 
 	let {
 		assets,
@@ -162,12 +162,8 @@
 								_resourceMetadata={{ resource_type: resourceDataCache[asset.path] }}
 							/>
 						{/if}
-						<MiniToggleButtonGroup
-							items={safeSelectItems(['r', 'w', 'rw'])}
-							error={!asset.access_type && !alternativeAccessType}
-							disabled={!!asset.access_type}
-							clearable
-							bind:value={
+						<ToggleButtonGroup
+							bind:selected={
 								() => asset.access_type ?? alternativeAccessType,
 								async (access_type) => {
 									alternativeAccessTypes ??= []
@@ -177,7 +173,13 @@
 									alternativeAccessTypes = val
 								}
 							}
-						/>
+						>
+							{#snippet children({ item })}
+								{#each ['r', 'w', 'rw'] as v}
+									<ToggleButton value={v} label={v} {item} />
+								{/each}
+							{/snippet}
+						</ToggleButtonGroup>
 					</div>
 				</li>
 			{/each}