From aa2f47390c73613f597e66b4ef24b3c84db188c2 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Thu, 26 Feb 2026 08:32:31 +0000 Subject: [PATCH] fix: remove duplicate num_columns in test_parse_relation test The num_columns i16 was written twice, causing the parser to read the second copy as column data and misparse the column name. Co-Authored-By: Claude Opus 4.6 --- backend/windmill-trigger-postgres/src/replication_message.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/backend/windmill-trigger-postgres/src/replication_message.rs b/backend/windmill-trigger-postgres/src/replication_message.rs index 3e0390b367..1c82dd978e 100644 --- a/backend/windmill-trigger-postgres/src/replication_message.rs +++ b/backend/windmill-trigger-postgres/src/replication_message.rs @@ -753,8 +753,7 @@ mod tests { buf.extend_from_slice(b"users\0"); // name buf.push(REPLICA_IDENTITY_DEFAULT_BYTE as u8); // replica identity buf.extend_from_slice(&1i16.to_be_bytes()); // num columns - buf.extend_from_slice(&1i16.to_be_bytes()); // num columns - // column: flags=0, name="id", type_oid=23 (INT4), type_modifier=-1 + // column: flags=0, name="id", type_oid=23 (INT4), type_modifier=-1 buf.push(0); // flags buf.extend_from_slice(b"id\0"); // name buf.extend_from_slice(&23u32.to_be_bytes()); // type_oid (INT4)