From b4e2dd4aa970bd2bcca43273874c68e36fc4a673 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Wed, 8 Jul 2026 09:25:39 +0000 Subject: [PATCH] docs: correct stale 3.11 python-fallback comments to reference the default The lockfile-less python fallback returns PyVAlias::default(), which moved from 3.11 to 3.12 in #7405. Update the comments and the dedicated-worker warn log to reference "the default version" instead of a hardcoded 3.11 so they stay correct across future latest-stable bumps. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) --- backend/windmill-worker/src/python_executor.rs | 2 +- backend/windmill-worker/src/python_versions.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/windmill-worker/src/python_executor.rs b/backend/windmill-worker/src/python_executor.rs index 9ca79c6852..4d9fc29d61 100644 --- a/backend/windmill-worker/src/python_executor.rs +++ b/backend/windmill-worker/src/python_executor.rs @@ -3445,7 +3445,7 @@ pub async fn start_worker( let py_version = if let Some(requirements) = requirements_o { PyV::parse_from_requirements(&split_python_requirements(requirements.as_str())) } else { - tracing::warn!(workspace_id = %w_id, "lockfile is empty for dedicated worker, thus python version cannot be inferred. Fallback to 3.11"); + tracing::warn!(workspace_id = %w_id, "lockfile is empty for dedicated worker, thus python version cannot be inferred. Fallback to default python version"); PyVAlias::default().into() }; diff --git a/backend/windmill-worker/src/python_versions.rs b/backend/windmill-worker/src/python_versions.rs index 3a1f35a302..8ca584affa 100644 --- a/backend/windmill-worker/src/python_versions.rs +++ b/backend/windmill-worker/src/python_versions.rs @@ -372,10 +372,10 @@ impl PyV { } /// Parse lockfile for assigned python version. - /// If not found returns 3.11 + /// If not found returns the default version (`PyVAlias::default()`). pub fn parse_from_requirements>(requirements_lines: &[S]) -> Self { Self::try_parse_from_requirements(requirements_lines).unwrap_or( - // If there is no assigned version in lockfile we automatically fallback to 3.11 + // If there is no assigned version in lockfile we automatically fallback to the default version // In this case we have dependencies or other metadata, but no associated python version // This is the case for old deployed scripts PyVAlias::default().into(),