From b83eeefd66b76143bd20378b13ecc6a0807e9e57 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Thu, 6 Nov 2025 13:04:00 +0000 Subject: [PATCH] logs improvements --- backend/ee-repo-ref.txt | 2 +- backend/windmill-api/src/jobs.rs | 10 +++++++++- frontend/src/lib/components/LogViewer.svelte | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/backend/ee-repo-ref.txt b/backend/ee-repo-ref.txt index d458ab9755..7c08288f4e 100644 --- a/backend/ee-repo-ref.txt +++ b/backend/ee-repo-ref.txt @@ -1 +1 @@ -8ab9b8d3cb7486fcb472d34f3a0b49f52548fe8f +44c4865023e6277468a69d866ea1a0b0c84eeb7a \ No newline at end of file diff --git a/backend/windmill-api/src/jobs.rs b/backend/windmill-api/src/jobs.rs index 0293b4b625..33beb32ec6 100644 --- a/backend/windmill-api/src/jobs.rs +++ b/backend/windmill-api/src/jobs.rs @@ -7023,6 +7023,11 @@ pub fn start_job_update_sse_stream( // Update log offset if available if let Some(new_offset) = update.log_offset { if new_offset != log_offset.unwrap_or(0) { + // let logs = update.new_logs.clone().unwrap_or_default(); + // tracing::error!( + // "new_offset: {new_offset}; log_offset: {log_offset:?}; {} {logs}", + // logs.len() + // ); log_offset = Some(new_offset); } else { update.log_offset = None; @@ -7364,7 +7369,10 @@ async fn get_job_update_data( } let job = if record.completed.unwrap_or(false) && get_full_job_on_completion { - let get = GetQuery::new().with_auth(&opt_authed).without_logs(); + let get = GetQuery::new() + .with_auth(&opt_authed) + .without_logs() + .without_code(); Some(get.fetch(&db, job_id, &w_id).await?) } else { None diff --git a/frontend/src/lib/components/LogViewer.svelte b/frontend/src/lib/components/LogViewer.svelte index 1de60d44d5..336304c749 100644 --- a/frontend/src/lib/components/LogViewer.svelte +++ b/frontend/src/lib/components/LogViewer.svelte @@ -156,6 +156,7 @@ lastJobId = jobId loadedFromObjectStore = '' LOG_LIMIT = LOG_INC + scroll = true } }) let truncatedContent = $derived(truncateContent(content, loadedFromObjectStore, LOG_LIMIT))