diff --git a/frontend/src/lib/components/schema/FlowPropertyEditor.svelte b/frontend/src/lib/components/schema/FlowPropertyEditor.svelte index 5211b4e472..f61a687f79 100644 --- a/frontend/src/lib/components/schema/FlowPropertyEditor.svelte +++ b/frontend/src/lib/components/schema/FlowPropertyEditor.svelte @@ -139,36 +139,36 @@ $: schemaUpdate(schema) let variantName = '' - function createVariant() { + function createVariant(name: string) { if (schema.oneOf) { - if (schema.oneOf.some((obj) => obj.title === variantName)) { + if (schema.oneOf.some((obj) => obj.title === name)) { throw new Error('Variant name already exists') } - const idx = schema.oneOf.findIndex((obj) => obj.title === variantName) + const idx = schema.oneOf.findIndex((obj) => obj.title === name) if (idx === -1) { schema.oneOf = [ ...schema.oneOf, { - title: variantName, + title: name, type: 'object', properties: {} } ] - oneOfSelected = variantName + oneOfSelected = name } variantName = '' } } - function renameVariant(selected: string) { + function renameVariant(selected: string, name: string) { if (schema.oneOf) { - if (schema.oneOf.some((obj) => obj.title === variantName)) { + if (schema.oneOf.some((obj) => obj.title === name)) { throw new Error('Variant name already exists') } const idx = schema.oneOf.findIndex((obj) => obj.title === selected) if (idx !== -1) { - schema.oneOf[idx].title = variantName - oneOfSelected = variantName + schema.oneOf[idx].title = name + oneOfSelected = name } variantName = '' } @@ -176,14 +176,6 @@ let initialObjectSelected = Object.keys(schema?.properties ?? {}).length == 0 ? 'resource' : 'custom-object' - - let disabledVariantName = true - // The purpose of this function is to avoid a re-render of the popover when the variant name changes. - // When the popover content is re-rendered, the popover glitches. - function updateVariantName(value: string) { - variantName = value - disabledVariantName = value.length === 0 - }