starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-21 16:03:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(drafts): settle what a schedule toggle queues, and void a removal marker any write outlives

Browse Source 
Toggling enable writes the form before awaiting the deploy, so the autosave
queues a draft against the pre-toggle baseline. Advancing the baseline on
success then made that draft equal to it — invisible to the banner, still a row
on the server and a `*` on the list. It is settled now, keeping an unrelated
edit made during the request the way a save does.

A draft-only removal marker was only ever voided by a chat write, so one left
unread — discarded outside a session, where nothing consumes it — could be spent
by an ordinary discard on a path since recreated, sending live editors away from
an item that exists. Every write that gives the item a draft again voids it,
which is also what `persistGlobalDraft` was doing by hand.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KcyBRxE8j3ujCYkum9KrC4
This commit is contained in:
Diego Imbert
2026-09-06 10:08:35 +02:00
co-authored by Claude Opus 5
parent 069d66627d
commit bfc9db5dfd
3 changed files with 25 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/copilot/chat/global/userDraftAdapter.ts
-3
View File
@@ -421,9 +421,6 @@ export async function persistGlobalDraft(
const itemKind = itemKindFor(type, opts.triggerKind)
if (!itemKind) throw new Error(`Unsupported draft type "${type}".`)
const storagePath = resolveDraftStoragePath(workspace, itemKind, path)
// Writing the item back means it exists again, so any removal marker left from
// an earlier draft-only discard is void.
UserDraft.clearDraftOnlyDiscard(itemKind, storagePath, { workspace })
UserDraft.seed(itemKind, storagePath, value, { workspace })
await UserDraftDbSyncer.save({
workspace,
frontend/src/lib/components/triggers/schedules/ScheduleEditorInner.svelte
+18 -5
View File
@@ -626,10 +626,10 @@
const isSaved = await saveScheduleFromCfg(scheduleCfg, edit, wsId!)
if (isSaved) {
// A create deploys the schedule enabled whatever the form said (see
// saveScheduleFromCfg), so what counts as written records that — otherwise
// the baseline below claims a state the server does not have. The form
// follows only while it still holds what was sent: changed during the
// request, it is a newer edit, and `keptEdit` below is what protects it.
// saveScheduleFromCfg), so what counts as written records that — the
// baseline would otherwise claim a state the server does not have. The form
// follows only while it still holds what was sent; changed since, it is an
// edit of its own.
if (wasCreate) {
const sentEnabled = scheduleCfg.enabled
scheduleCfg.enabled = true
@@ -776,7 +776,20 @@
if (initialConfig) initialConfig.enabled = nEnabled
// This request carried the enabled flag alone: anything else the form has
// diverged into is an edit of the user's, which a remount would drop.
onUpdate?.(path, path, ws, !draftValuesEqual(getScheduleCfg(), initialConfig))
const keptEdit = !draftValuesEqual(getScheduleCfg(), initialConfig)
// Setting `enabled` above queued a draft against the pre-toggle baseline.
// It matches the new one, so nothing would ever show it again — but it is
// still a row on the server and a `*` on the list until it is settled away.
if (initialConfig)
settleDraftAfterWrite(
'trigger_schedule',
$state.snapshot(initialConfig),
getScheduleCfg(),
path,
path,
{ workspace: ws ?? undefined }
)
onUpdate?.(path, path, ws, keptEdit)
}
}