From c3292f10e8a130a51080836c47bbc2f1105a04bf Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Fri, 29 Sep 2023 00:39:17 +0200
Subject: [PATCH] fix: non skipped failures stop even in presence of an error
 handler

---
 backend/windmill-worker/src/worker_flow.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/windmill-worker/src/worker_flow.rs b/backend/windmill-worker/src/worker_flow.rs
index a4b855214c..21d5df24d7 100644
--- a/backend/windmill-worker/src/worker_flow.rs
+++ b/backend/windmill-worker/src/worker_flow.rs
@@ -639,7 +639,7 @@ pub async fn update_flow_status_after_job_completion_internal<
             return Ok(Some(RecUpdateFlowStatusAfterJobCompletion {
                 flow: parent_job,
                 job_id_for_status: flow,
-                success,
+                success: success && !is_failure_step,
                 result: nresult,
                 stop_early_override: if stop_early {
                     Some(skip_if_stop_early)