From c3971f99fcc4df6cece0f7dee1cf155c4ddbe90c Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Tue, 29 Jul 2025 12:40:37 +0000
Subject: [PATCH] support $res: string in form inputs of arrays

---
 frontend/src/lib/components/ArgInput.svelte   | 48 ++++++++++++++-----
 .../(root)/(logged)/resources/+page.svelte    | 12 ++++-
 2 files changed, 47 insertions(+), 13 deletions(-)

diff --git a/frontend/src/lib/components/ArgInput.svelte b/frontend/src/lib/components/ArgInput.svelte
index 81189d614e..5e197fcab5 100644
--- a/frontend/src/lib/components/ArgInput.svelte
+++ b/frontend/src/lib/components/ArgInput.svelte
@@ -9,7 +9,7 @@
 		emptyString,
 		getSchemaFromProperties
 	} from '$lib/utils'
-	import { DollarSign, Plus, X, Check, Loader2 } from 'lucide-svelte'
+	import { DollarSign, Plus, X, Check, Loader2, ExternalLink } from 'lucide-svelte'
 	import { createEventDispatcher, onDestroy, onMount, tick, untrack } from 'svelte'
 	import { fade } from 'svelte/transition'
 	import { Button, SecondsInput } from './common'
@@ -41,6 +41,7 @@
 	import MultiSelect from './select/MultiSelect.svelte'
 	import { safeSelectItems } from './select/utils.svelte'
 	import S3ArgInput from './common/fileUpload/S3ArgInput.svelte'
+	import { base } from '$lib/base'
 
 	interface Props {
 		label?: string
@@ -496,6 +497,29 @@
 	})
 </script>
 
+{#snippet variableInput()}
+	{#if variableEditor}
+		<div class="text-sm text-tertiary">
+			{#if value && typeof value == 'string' && value?.startsWith('$var:')}
+				Linked to variable <button
+					class="text-blue-500 underline"
+					onclick={() => variableEditor?.editVariable?.(value.slice(5))}>{value.slice(5)}</button
+				>
+			{/if}
+		</div>
+	{/if}
+{/snippet}
+{#snippet resourceInput()}
+	{#if variableEditor}
+		<div class="text-sm text-tertiary">
+			{#if value && typeof value == 'string' && value?.startsWith('$res:')}
+				Linked to resource <a target="_blank" href="{base}/resources#/resource/{value.slice(5)}"
+					class="text-blue-500 underline">{value.slice(5)} <span class="inline-block -mb-0.5" ><ExternalLink size={14} /></span></a
+				>
+			{/if}
+		</div>
+	{/if}
+{/snippet}
 <!-- svelte-ignore a11y_autofocus -->
 <div
 	class={twMerge(
@@ -770,6 +794,15 @@
 											>{itemsLimit}/{value.length}: Load 50 more...</button
 										>
 									{/if}
+								{:else if typeof value === 'string'}
+									{#if value.startsWith('$res:')}
+										{@render resourceInput()}
+									{:else}
+										<div class="text-red-500">
+											Invalid string value: "{value}", expected array. Click add item to turn it
+											into an array.
+										</div>
+									{/if}
 								{/if}
 							{/key}
 						</div>
@@ -1240,17 +1273,8 @@
 						{/if}
 					{/if}
 				</div>
-				{#if variableEditor}
-					<div class="text-sm text-tertiary">
-						{#if value && typeof value == 'string' && value?.startsWith('$var:')}
-							Linked to variable <button
-								class="text-blue-500 underline"
-								onclick={() => variableEditor?.editVariable?.(value.slice(5))}
-								>{value.slice(5)}</button
-							>
-						{/if}
-					</div>
-				{/if}
+				{@render variableInput()}
+				{@render resourceInput()}
 			</div>
 		{/if}
 		{@render actions?.()}
diff --git a/frontend/src/routes/(root)/(logged)/resources/+page.svelte b/frontend/src/routes/(root)/(logged)/resources/+page.svelte
index 1c0a8172c7..b3f0118584 100644
--- a/frontend/src/routes/(root)/(logged)/resources/+page.svelte
+++ b/frontend/src/routes/(root)/(logged)/resources/+page.svelte
@@ -417,6 +417,16 @@
 		}
 	})
 
+	onMount(() => {
+		let hash = $page.url.hash
+		if (hash.startsWith('#/resource/')) {
+			console.log('hash', hash)
+			let path = hash.slice(11)
+			resourceEditor?.initEdit(path)
+			
+		}
+	})
+
 	let dbManagerDrawer: DbManagerDrawer | undefined = $state()
 </script>
 
@@ -788,7 +798,7 @@
 										<Cell>
 											<a
 												class="break-all"
-												href="#{path}"
+												href="#/resource/{path}"
 												onclick={() => resourceEditor?.initEdit?.(path)}
 												>{#if marked}{@html marked}{:else}{path}{/if}</a
 											>