From c9ddddda1b1dd917c323f94c57e8247b42a9abb8 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Fri, 14 Aug 2026 21:15:33 +0200
Subject: [PATCH] log the settings a failed read left unapplied (#10709)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 backend/src/monitor.rs | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/backend/src/monitor.rs b/backend/src/monitor.rs
index ab40597c9d..93ad5945b8 100644
--- a/backend/src/monitor.rs
+++ b/backend/src/monitor.rs
@@ -3235,6 +3235,10 @@ impl<'a> SettingsPass<'a> {
                 PassStep::Setting { name, apply, .. } => {
                     if let Some(value) = values.remove(name) {
                         apply(value).await
+                    } else {
+                        tracing::warn!(
+                            "Setting {name} could not be read, leaving its in-memory value unchanged"
+                        );
                     }
                 }
                 PassStep::Settings { names, apply, .. } => {
@@ -3244,6 +3248,17 @@ impl<'a> SettingsPass<'a> {
                         .collect();
                     if asked.len() == names.len() {
                         apply(asked).await
+                    } else {
+                        let missing = names
+                            .iter()
+                            .filter(|n| !asked.contains_key(*n))
+                            .copied()
+                            .collect::<Vec<_>>()
+                            .join(", ");
+                        tracing::warn!(
+                            "Settings {missing} could not be read, leaving the in-memory values of {} unchanged",
+                            names.join(", ")
+                        );
                     }
                 }
                 PassStep::Action(fut) => fut.await,