From ccd24e610c8a06a72046f44c18e775b15f114c95 Mon Sep 17 00:00:00 2001 From: Guilhem Date: Wed, 28 May 2025 10:19:31 +0200 Subject: [PATCH] triggers panel polishing (#5825) * Allways use custom label for triggers * Add default path name for new schedule * Improve warning message * Add confirmation modal for deleting triggers --- .../src/lib/components/SchedulePanel.svelte | 4 +- .../components/triggers/CaptureSection.svelte | 3 +- .../triggers/DeleteTriggerButton.svelte | 53 +++++++++++++++++++ .../triggers/TriggerEditorToolbar.svelte | 36 +++++-------- .../components/triggers/TriggersTable.svelte | 12 ++--- .../triggers/TriggersWrapper.svelte | 18 +++---- .../triggers/gcp/GcpTriggerEditorInner.svelte | 13 ++--- .../triggers/gcp/GcpTriggerPanel.svelte | 3 +- .../triggers/http/RouteEditorInner.svelte | 10 ++-- .../triggers/http/RoutesPanel.svelte | 3 +- .../kafka/KafkaTriggerEditorInner.svelte | 11 ++-- .../triggers/kafka/KafkaTriggersPanel.svelte | 3 +- .../mqtt/MqttTriggerEditorInner.svelte | 13 ++--- .../triggers/mqtt/MqttTriggersPanel.svelte | 3 +- .../nats/NatsTriggerEditorInner.svelte | 13 ++--- .../triggers/nats/NatsTriggersPanel.svelte | 3 +- .../PostgresTriggerEditorInner.svelte | 13 ++--- .../postgres/PostgresTriggersPanel.svelte | 3 +- .../schedules/ScheduleEditorInner.svelte | 20 ++++--- .../triggers/sqs/SqsTriggerEditorInner.svelte | 13 ++--- .../triggers/sqs/SqsTriggerPanel.svelte | 3 +- .../WebsocketTriggerEditorInner.svelte | 13 ++--- .../websocket/WebsocketTriggersPanel.svelte | 3 +- 23 files changed, 136 insertions(+), 133 deletions(-) create mode 100644 frontend/src/lib/components/triggers/DeleteTriggerButton.svelte diff --git a/frontend/src/lib/components/SchedulePanel.svelte b/frontend/src/lib/components/SchedulePanel.svelte index b6240534b4..334adcb98c 100644 --- a/frontend/src/lib/components/SchedulePanel.svelte +++ b/frontend/src/lib/components/SchedulePanel.svelte @@ -33,9 +33,7 @@ bind:this={scheduleEditor} hideTarget allowDraft - hasDraft={!!selectedTrigger.draftConfig} - isDraftOnly={selectedTrigger.isDraft} - primary={selectedTrigger.isPrimary} + trigger={selectedTrigger} draftSchema={schema} {customLabel} {...restProps} diff --git a/frontend/src/lib/components/triggers/CaptureSection.svelte b/frontend/src/lib/components/triggers/CaptureSection.svelte index e02ef909f1..06b540f78e 100644 --- a/frontend/src/lib/components/triggers/CaptureSection.svelte +++ b/frontend/src/lib/components/triggers/CaptureSection.svelte @@ -307,7 +307,8 @@
{#if displayAlert} - Capturing will suscribe to the trigger endpoint. Treat carefully. + Capturing on a deployed trigger can cause event loss on the deployed trigger. Treat + carefully. {/if} diff --git a/frontend/src/lib/components/triggers/DeleteTriggerButton.svelte b/frontend/src/lib/components/triggers/DeleteTriggerButton.svelte new file mode 100644 index 0000000000..d65c26a01d --- /dev/null +++ b/frontend/src/lib/components/triggers/DeleteTriggerButton.svelte @@ -0,0 +1,53 @@ + + + { + confirmationModalOpen = false + }} + on:confirmed={() => { + onDelete?.() + confirmationModalOpen = false + }} +> + {#if trigger !== undefined} + {@const IconComponent = triggerIconMap[trigger.type]} +
+ + +
+ {/if} +
+ +