From ce51362ae80deff3fdbc0ae81503aa09a17d9b73 Mon Sep 17 00:00:00 2001
From: Faton Ramadani <faton.ramadani14@gmail.com>
Date: Fri, 10 Nov 2023 10:26:22 +0100
Subject: [PATCH] =?UTF-8?q?feat(frontend):=20draft=20script/flow=20can=20o?=
 =?UTF-8?q?nly=20access=20the=20edit=20page=20until=E2=80=A6=20(#2607)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* feat(frontend): draft script/flow can only access the edit page until deployed

* feat(frontend): remove redirect
---
 .../src/lib/components/FlowBuilder.svelte     | 10 ++++++----
 .../src/lib/components/ScriptBuilder.svelte   | 19 ++++++++++++-------
 .../common/button/ButtonDropdown.svelte       |  2 +-
 .../components/common/table/FlowRow.svelte    |  4 +++-
 .../components/common/table/ScriptRow.svelte  |  2 +-
 .../(logged)/flows/get/[...path]/+page.svelte |  1 -
 6 files changed, 23 insertions(+), 15 deletions(-)

diff --git a/frontend/src/lib/components/FlowBuilder.svelte b/frontend/src/lib/components/FlowBuilder.svelte
index 981387096f..6a33ac03fd 100644
--- a/frontend/src/lib/components/FlowBuilder.svelte
+++ b/frontend/src/lib/components/FlowBuilder.svelte
@@ -420,12 +420,14 @@
 	const dropdownItems: Array<{
 		label: string
 		onClick: () => void
-	}> = [
-		{
+	}> = []
+
+	if (savedFlow?.draft_only === false) {
+		dropdownItems.push({
 			label: 'Exit & see details',
 			onClick: () => dispatch('details', $pathStore)
-		}
-	]
+		})
+	}
 
 	if (!newFlow) {
 		dropdownItems.push({
diff --git a/frontend/src/lib/components/ScriptBuilder.svelte b/frontend/src/lib/components/ScriptBuilder.svelte
index 49ca84f40b..ee03ada182 100644
--- a/frontend/src/lib/components/ScriptBuilder.svelte
+++ b/frontend/src/lib/components/ScriptBuilder.svelte
@@ -314,12 +314,16 @@
 								window.open(`/scripts/add?template=${initialPath}`)
 							}
 						},
-						{
-							label: 'Exit & See details',
-							onClick: () => {
-								goto(`/scripts/get/${initialPath}?workspace=${$workspaceStore}`)
-							}
-						}
+						...(!script.draft_only
+							? [
+									{
+										label: 'Exit & See details',
+										onClick: () => {
+											goto(`/scripts/get/${initialPath}?workspace=${$workspaceStore}`)
+										}
+									}
+							  ]
+							: [])
 				  ]
 				: []
 
@@ -584,7 +588,8 @@
 											</div>
 										{:else}
 											<div class="text-sm text-secondary flex flex-row gap-2">
-												No custom worker group tag defined on this instance in "Workers {"->"} Assignable Tags"
+												No custom worker group tag defined on this instance in "Workers {'->'} Assignable
+												Tags"
 												<a
 													href="https://www.windmill.dev/docs/core_concepts/worker_groups"
 													target="_blank"
diff --git a/frontend/src/lib/components/common/button/ButtonDropdown.svelte b/frontend/src/lib/components/common/button/ButtonDropdown.svelte
index 7b0311063f..9bc8009a8b 100644
--- a/frontend/src/lib/components/common/button/ButtonDropdown.svelte
+++ b/frontend/src/lib/components/common/button/ButtonDropdown.svelte
@@ -6,7 +6,7 @@
 	import Portal from 'svelte-portal'
 
 	export let hasPadding: boolean = true
-	export let target: string | undefined = undefined
+	export let target: string | undefined = 'body'
 	const [popperRef, popperContent] = createPopperActions({ placement: 'auto' })
 
 	const popperOptions: PopperOptions<{}> = {
diff --git a/frontend/src/lib/components/common/table/FlowRow.svelte b/frontend/src/lib/components/common/table/FlowRow.svelte
index f6313f7099..65da8f7034 100644
--- a/frontend/src/lib/components/common/table/FlowRow.svelte
+++ b/frontend/src/lib/components/common/table/FlowRow.svelte
@@ -74,7 +74,9 @@
 {/if}
 
 <Row
-	href="/flows/get/{path}?workspace={$workspaceStore}"
+	href={draft_only
+		? `/flows/edit/${path}?nodraft=true`
+		: `/flows/get/${path}?workspace=${$workspaceStore}`}
 	kind="flow"
 	workspaceId={workspace_id ?? $workspaceStore ?? ''}
 	{marked}
diff --git a/frontend/src/lib/components/common/table/ScriptRow.svelte b/frontend/src/lib/components/common/table/ScriptRow.svelte
index f0d250de20..cb5957ca28 100644
--- a/frontend/src/lib/components/common/table/ScriptRow.svelte
+++ b/frontend/src/lib/components/common/table/ScriptRow.svelte
@@ -93,7 +93,7 @@
 {/if}
 
 <Row
-	href="/scripts/get/{hash}?workspace={$workspaceStore}"
+	href={draft_only ? `/scripts/edit/${path}` : `/scripts/get/${hash}?workspace=${$workspaceStore}`}
 	kind="script"
 	{marked}
 	{path}
diff --git a/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte
index 478b6a1420..df7d65c074 100644
--- a/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte
+++ b/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte
@@ -45,7 +45,6 @@
 	let can_write = false
 	let path = $page.params.path
 	let shareModal: ShareModal
-
 	let deploymentInProgress = false
 
 	$: cliCommand = `wmill flow run ${flow?.path} -d '${JSON.stringify(args)}'`