From cfa20ae0d740014baea2e534cea5f787acaeb028 Mon Sep 17 00:00:00 2001
From: HugoCasa <hugo@casademont.ch>
Date: Tue, 6 Aug 2024 21:59:29 +0200
Subject: [PATCH] fix: mysql support for underscore in named param (#4200)

---
 backend/parsers/windmill-parser-sql/src/lib.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/backend/parsers/windmill-parser-sql/src/lib.rs b/backend/parsers/windmill-parser-sql/src/lib.rs
index c97e291648..2f44667e4d 100644
--- a/backend/parsers/windmill-parser-sql/src/lib.rs
+++ b/backend/parsers/windmill-parser-sql/src/lib.rs
@@ -341,7 +341,7 @@ pub fn parse_sql_statement_named_params(code: &str, prefix: char) -> HashSet<Str
         |_, chars| {
             let mut arg_name = String::new();
             while let Some(&(_, char)) = chars.peek() {
-                if char.is_alphanumeric() {
+                if char.is_alphanumeric() || char == '_' {
                     arg_name.push(char);
                     chars.next();
                 } else {
@@ -751,8 +751,8 @@ SELECT ?, ?;
         let code = r#"
 -- :param1 (int) = 3
 -- :param2 (text)
--- :param3 (text)
-SELECT :param3, :param1;
+-- :param_3 (text)
+SELECT :param_3, :param1;
 SELECT :param2;
 "#;
         assert_eq!(
@@ -779,7 +779,7 @@ SELECT :param2;
                     },
                     Arg {
                         otyp: Some("text".to_string()),
-                        name: "param3".to_string(),
+                        name: "param_3".to_string(),
                         typ: Typ::Str(None),
                         default: None,
                         has_default: false,