From d3bc4c4e52c572724330713af2a1f67a49535993 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Sun, 8 Feb 2026 21:41:50 +0000 Subject: [PATCH] fix: add missing :name param to groups/is_owner route The handler expected Path((w_id, name)) but the route was registered as /is_owner without :name, making the endpoint unreachable. Co-Authored-By: Claude Opus 4.6 --- backend/tests/groups.rs | 8 ++++++++ backend/windmill-api-groups/src/groups.rs | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/backend/tests/groups.rs b/backend/tests/groups.rs index c996c4c629..0fb37fdec4 100644 --- a/backend/tests/groups.rs +++ b/backend/tests/groups.rs @@ -128,6 +128,14 @@ async fn test_group_endpoints(db: Pool) -> anyhow::Result<()> { .unwrap(); assert_eq!(resp.status(), 200); + // --- is_owner --- + let resp = authed(client().get(group_url(port, "is_owner", "test_group"))) + .send() + .await + .unwrap(); + assert_eq!(resp.status(), 200); + assert_eq!(resp.json::().await?, true); + // --- delete --- let resp = authed(client().delete(group_url(port, "delete", "another_group"))) .send() diff --git a/backend/windmill-api-groups/src/groups.rs b/backend/windmill-api-groups/src/groups.rs index 9a66531329..a68b72072d 100644 --- a/backend/windmill-api-groups/src/groups.rs +++ b/backend/windmill-api-groups/src/groups.rs @@ -38,7 +38,7 @@ pub fn workspaced_service() -> Router { .route("/delete/:name", delete(delete_group)) .route("/adduser/:name", post(add_user)) .route("/removeuser/:name", post(remove_user)) - .route("/is_owner", get(is_owner)) + .route("/is_owner/:name", get(is_owner)) } pub fn global_service() -> Router {