From d76e90757e209263da7f79fa85052969e7efd63d Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Fri, 21 Apr 2023 23:48:13 +0200 Subject: [PATCH] fix(backend): avoid potential conflict between pull from tar and background sync --- backend/windmill-worker/src/global_cache.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/windmill-worker/src/global_cache.rs b/backend/windmill-worker/src/global_cache.rs index ef9f2afa02..0e79eb39c0 100644 --- a/backend/windmill-worker/src/global_cache.rs +++ b/backend/windmill-worker/src/global_cache.rs @@ -78,7 +78,7 @@ pub async fn pull_from_tar(bucket: &str, folder: String) -> error::Result<()> { let start = Instant::now(); let tar_path = format!("tar/pip/{folder_name}.tar"); - let target = format!("{ROOT_TMP_CACHE_DIR}/{tar_path}"); + let target = format!("{ROOT_TMP_CACHE_DIR}/{tar_path}.single"); if let Err(e) = execute_command( ROOT_TMP_CACHE_DIR, "rclone", @@ -111,6 +111,7 @@ pub async fn pull_from_tar(bucket: &str, folder: String) -> error::Result<()> { } extract_pip_tar(&target, &folder).await?; + tokio::fs::remove_file(&target).await?; tracing::info!( "Finished pulling and extracting {folder_name}. Took {:?}ms", start.elapsed().as_millis()